Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up name API #1

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Clean up name API #1

merged 7 commits into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. Move InvalidDnsNameError definition down below usage

    @djc
    djc committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d8c05e1 View commit details
    Browse the repository at this point in the history

  2. Move GeneralDnsNameRef definition to the top

    @djc
    djc committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    221fd4a View commit details
    Browse the repository at this point in the history

  3. Refactor faux-bool enum definition for AllowWildcards

    @djc
    djc committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4e169bb View commit details
    Browse the repository at this point in the history

  4. Use as_str() method to reference DnsNameRef contents 

    The From impl feels a little unidiomatic because the DnsNameRef is not
consumed. An AsRef impl would unnecessarily constrain the lifetime of
the output value to `&self`, whereas it can live as long as `'a`.
    @djc
    djc committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    51f23a4 View commit details
    Browse the repository at this point in the history

  5. Use as_str() method to reference WildcardDnsNameRef contents 

    The From impl feels a little unidiomatic because the WildcardDnsNameRef is
not consumed. An AsRef impl would unnecessarily constrain the lifetime of
the output value to `&self`, whereas it can live as long as `'a`.
    @djc
    djc committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    941589c View commit details
    Browse the repository at this point in the history

  6. Use as_str() method to reference GeneralDnsNameRef contents 

    The From impl feels a little unidiomatic because the GeneralDnsNameRef is
not consumed. An AsRef impl would unnecessarily constrain the lifetime of
the output value to `&self`, whereas it can live as long as `'a`.
    @djc
    djc committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d5bc8e9 View commit details
    Browse the repository at this point in the history

  7. Remove API that is now unused

    @djc
    djc committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    27a1234 View commit details
    Browse the repository at this point in the history