Fix failing decode of credentials #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Reading the docs I see DecodeLen is the max size it could be not the actual size.
So LGTM.
I don't think we can ever hit the n > decodeLen case because it can't be longer than the buffer we pass in, which is the max size it could possibly be anyway.
But this is fine as is.
|
Added a v0.3.1 tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced an issue where this library failed to read some credentials. The credentials are set via
docker login.The check that compares the number of written bytes with the maximum length in bytes is too restrictive.
The Docker CLI implements the check a bit differently (link to source).
This change aligns the check with what the Docker CLI is doing.