Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend table preprocessor #111

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Prepend table preprocessor #111

merged 1 commit into from
Feb 26, 2024

Conversation

cpuguy83
Copy link
Owner

@cpuguy83 cpuguy83 commented Feb 4, 2024

When a table is present we need to instruct groff to enable the table preprocessor.
This surpresses warnings from groff.

Fixes #99

When a table is present we need to instruct the groff to enable the
table preprocessor.
This surpresses warnings from groff.

Signed-off-by: Brian Goff <[email protected]>
@thaJeztah
Copy link
Collaborator

For others; this is easier to review with whitespace disabled in the diff; https://github.com/cpuguy83/go-md2man/pull/111/files?w=1

Screenshot 2024-02-05 at 10 22 20

Copy link
Collaborator

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"LGTM" but take that with a good grain of salt; code changes look good, but I'm not good at roff, so wouldn't hurt to have more eyes to verify correctness.

@g-branden-robinson
Copy link

I hope I qualify as good at roff, but anytime I find myself unable to solve a problem in it with minimal effort, I wonder...

The roff change part of this LGTM.

@cpuguy83 cpuguy83 merged commit c2c0656 into master Feb 26, 2024
5 checks passed
@cpuguy83 cpuguy83 deleted the tbl_preprocessor branch February 26, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new groff incompatibilities?
3 participants