-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converts project to use dep #29
Conversation
updated to v1.5 by simply running |
|
||
[[constraint]] | ||
name = "github.com/russross/blackfriday" | ||
version = "1.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you haven't been following dep closely, this line may surprise you. In other package managers, this would look like I'd pinned you specifically to v1.4 and yet somehow, the lock file now shows v1.5. In dep, undecorated constraints are implicitly carot requirements. So this line really means 1.4 <= version < 2.0.0
which is essentially what we want. dep ensure -update
respects the existing manifest and only updates the lockfile and vendor folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
FYI, @cpuguy83 you'll need to tag a new release in order to fully resolve this problem. downstream dep users still break on this because they pull in your latest tagged release ( v1.0.6) which does't have this change. |
@zevdg Thanks for pointing that out! I've tagged a new release (v1.0.7) |
As discussed in #28
Ok, so switching to dep itself was fairly straightforward. As for the dependency changes:
I could have change the dep constraint to ignore semver and just track the master branch to avoid this downgrade, but that felt dirty. Instead, I asked them to roll a new v1 release at russross/blackfriday#383 (comment)
I'd recommend holding off on merging this until they respond there to avoid any potential regressions that could result from downgrading that dependency.