Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converts project to use dep #29

Merged
merged 2 commits into from
Aug 27, 2017
Merged

converts project to use dep #29

merged 2 commits into from
Aug 27, 2017

Conversation

zevdg
Copy link
Contributor

@zevdg zevdg commented Aug 24, 2017

As discussed in #28
Ok, so switching to dep itself was fairly straightforward. As for the dependency changes:

  • github.com/shurcooL/sanitized_anchor_name was updated a few commits, but the code hasn't changed at all
  • github.com/russross/blackfriday actually got downgraded several commits because the last v1.x release is relatively old and by default, dep prefers tagged semver releases.

I could have change the dep constraint to ignore semver and just track the master branch to avoid this downgrade, but that felt dirty. Instead, I asked them to roll a new v1 release at russross/blackfriday#383 (comment)

I'd recommend holding off on merging this until they respond there to avoid any potential regressions that could result from downgrading that dependency.

@rtfb
Copy link

rtfb commented Aug 26, 2017

@zevdg
Copy link
Contributor Author

zevdg commented Aug 26, 2017

updated to v1.5 by simply running dep ensure -update and committing. Interestingly, the sanitized_anchor_name dependency got swallowed by blackfriday at the request of @adg under russross/blackfriday#350, so your dep graph is super simple now.


[[constraint]]
name = "github.com/russross/blackfriday"
version = "1.4"
Copy link
Contributor Author

@zevdg zevdg Aug 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't been following dep closely, this line may surprise you. In other package managers, this would look like I'd pinned you specifically to v1.4 and yet somehow, the lock file now shows v1.5. In dep, undecorated constraints are implicitly carot requirements. So this line really means 1.4 <= version < 2.0.0 which is essentially what we want. dep ensure -update respects the existing manifest and only updates the lockfile and vendor folder.

Copy link
Owner

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cpuguy83 cpuguy83 merged commit 1d903dc into cpuguy83:master Aug 27, 2017
@zevdg
Copy link
Contributor Author

zevdg commented Aug 29, 2017

FYI, @cpuguy83 you'll need to tag a new release in order to fully resolve this problem. downstream dep users still break on this because they pull in your latest tagged release ( v1.0.6) which does't have this change.

@zevdg zevdg deleted the dep branch August 29, 2017 23:54
@cpuguy83
Copy link
Owner

@zevdg Thanks for pointing that out! I've tagged a new release (v1.0.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants