-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not escape dash, underscore, and ampersand #74
Conversation
The "disappearing ampersand" issue can be seen in docker-run(1) man page. Source:
man render:
(or online at http://manpages.org/docker-run, search for |
@estesp @thaJeztah @cpuguy83 PTAL |
.github/dependabot.yml
Outdated
@@ -0,0 +1,10 @@ | |||
version: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if we actually need dependabot (there's only a single module we depend on, and pushing it to a newer version also forces consumers of this module to update)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its fine to have... except its already merged so looks like a bad rebase here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how it ended up here. Rebased, seems fixed now.
sounds reasonable. I went looking in history to see if a specific reason was mentioned, but this function was part of the initial commit 6d7399d |
Yeah, I think the original implementation I was having problems with certain things and used that... indeed its been getting smaller and smaller. |
Currently, we escape a few characters, such as - (dash) becomes \- (arithmetic minus sign) _ (underscore) becomes \_ (underline character) & (ampersand) becomes \& (zero-width space) As a result, we have two bugs: 1. All & characters disappear from the resulting man page. 2. Dashes are quite longer, and underscores becomes underlines (the latter are lower). This is not reflected in text output, only in PDF etc, and in most cases (like file names, command line options etc) does not look good. In fact, the only character that needs escaping is the backslash itself. This is what this patch does, together with fixes to expected test output. Signed-off-by: Kir Kolyshkin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cool! I was looking at the |
Do you think we should do a new release? |
I was hoping to squash a couple more issues but the fixes weren’t quite right. |
commit 06c06c87dc02e5a7b50d9771ae4178bd10317e8d Merge: dcf3f60e a4015b7f Author: Nate Smith <[email protected]> Date: Fri Oct 15 15:14:49 2021 -0500 Merge pull request #3833 from cristiand391/gh-run-cancel Add `run cancel` command commit a4015b7f09438cfe1729a0112b55aa0939393787 Author: nate smith <[email protected]> Date: Fri Oct 15 15:08:53 2021 -0500 prompt tests commit f381a804fce659ec26ee02e27bd47afd0893a7d7 Author: nate smith <[email protected]> Date: Fri Oct 15 14:57:20 2021 -0500 fix tests commit 18975e61d135fc0d20049efea721dcad63d09652 Author: nate smith <[email protected]> Date: Fri Oct 15 14:31:29 2021 -0500 fix imports commit b81eda0c46baa6fd70ba4453ea0f66a9e5676c62 Author: nate smith <[email protected]> Date: Fri Oct 15 14:28:28 2021 -0500 newline commit f329ebd7cafd6a8492b7f924422107a457270a0d Author: nate smith <[email protected]> Date: Fri Oct 15 14:19:16 2021 -0500 add interactive prompt for in progress runs commit dcf3f60e00aa0888a1f1638afdc048413a9b3c84 Merge: 6f34e4a6 70c78f2a Author: Nate Smith <[email protected]> Date: Fri Oct 15 14:13:58 2021 -0500 Merge pull request #4007 from bchadwic/relative-path gh browse relative path enhancement commit 4a01e6b7021fba5f65f63b6fd17cd11230cea2c5 Merge: 49652cde 6f34e4a6 Author: nate smith <[email protected]> Date: Fri Oct 15 14:12:53 2021 -0500 Merge remote-tracking branch 'origin/trunk' into gh-run-cancel commit 6f34e4a6057260402c98ab9276912bd02930635c Author: Marwan Sulaiman <[email protected]> Date: Fri Oct 15 09:51:46 2021 -0400 Rename privacy sub-command to visibility (#4533) * Rename privacy sub-command to visibility * PR fixes commit dc614f66a91d98953c715ce2a728fa4bc6077b71 Merge: 9a86a2ee 1e52b4c7 Author: Mislav Marohnić <[email protected]> Date: Fri Oct 15 13:50:21 2021 +0200 Merge pull request #4529 from nickfyson/change_expected_status change expected delete status to 202 commit 1e52b4c7f95852c19158ff483cfa5beb1913e805 Author: Nick Fyson <[email protected]> Date: Fri Oct 15 12:30:11 2021 +0100 change expected delete status to 202 commit 9a86a2ee6a45a675478deb8f6c2cb37572180f7e Merge: 1aec8923 4504e49e Author: Jose Garcia <[email protected]> Date: Thu Oct 14 20:13:35 2021 -0400 Merge pull request #4524 from cli/jg/fix-trunk codespace: update running method commit 4504e49e960a994147271e560e1c023cb9c3e809 Author: Jose Garcia <[email protected]> Date: Thu Oct 14 20:02:02 2021 -0400 Update running method commit 1aec8923266f5b0ff7d48e916d3090640356516a Merge: f6b33572 5e56b4a7 Author: Jose Garcia <[email protected]> Date: Thu Oct 14 19:59:59 2021 -0400 Merge pull request #4520 from cli/jg/new-api-shape codespace: implement new API payload commit 70c78f2aa896f2c6baf9a045c087f1042fd4b62d Author: nate smith <[email protected]> Date: Thu Oct 14 17:07:51 2021 -0500 some fixes, streamlining commit f6b33572fddc0df381ba6323d0c05b605f462914 Merge: cb89b8ca 8f581fa4 Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 20:54:56 2021 +0200 Merge pull request #4279 from SiarheiFedartsou/sf-pr-list-head-filter Add `--head` filter to `gh pr list` commit cb89b8ca7a706cf51927477ad3f979ea4769e16e Merge: b0360612 defbf0f3 Author: Nate Smith <[email protected]> Date: Thu Oct 14 13:39:14 2021 -0500 Merge pull request #4442 from cli/cleanup-upgrade Cleanup extension upgrade command commit b0360612d21808304dc6d4c7cc18a4030e6cbb8b Merge: c2abe170 0748e658 Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 20:29:21 2021 +0200 Merge pull request #4521 from cli/jg/bind-locally codespace: switches port binding to 127.0.0.1 where possible commit c2abe170d85fee3314d7a72fe3b025d22da0e0f1 Merge: 78443964 1464a8a0 Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 20:29:12 2021 +0200 Merge pull request #4512 from cli/changelog-api Generate release notes using the new API commit 1464a8a0f35397ccdbf2c07aedddcbf35bd70c1d Author: Mislav Marohnić <[email protected]> Date: Wed Oct 13 20:51:37 2021 +0200 Generate release notes using the new API https://docs.github.com/en/rest/reference/repos#generate-release-notes-content-for-a-release commit 78443964d44394dc4fa0e313d94af2459f229359 Merge: 78ac7718 89ad8701 Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 20:21:13 2021 +0200 Merge pull request #4513 from cli/missing-oauth-scopes Warn about missing OAuth scopes when reporting HTTP 4xx errors commit 89ad87019043642fc8ef144fa51eb9b8e0601a5c Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 19:52:59 2021 +0200 auth refresh: preserve existing scopes when requesting new ones When there was a previously valid token that was granted some scopes, ensure all those scopes will be re-requested when doing the authentication flow for the new token. commit 4996ba2ba4e0d6c15b90a7cae35f06215290b542 Merge: 59930186 78ac7718 Author: nate smith <[email protected]> Date: Thu Oct 14 12:24:27 2021 -0500 Merge remote-tracking branch 'origin/trunk' into relative-path commit 64a19ee71feb0b5d1024227ff87e4104e36e896f Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 18:36:55 2021 +0200 Remove OAuth scopes checking logic from `ssh-key` commands Scopes checking is now handled on the HTTP client level for all commands. commit 78ac77180e833acaf233fb252d4c8e232800d603 Merge: b0905a41 5bdaab88 Author: Nate Smith <[email protected]> Date: Thu Oct 14 11:31:15 2021 -0500 Merge pull request #3950 from bchadwic/browse-commit Add feature open latest commit in gh browse commit 5bdaab882b77e2c870a50d208284dc5c374108c1 Author: nate smith <[email protected]> Date: Thu Oct 14 11:25:33 2021 -0500 fix commit 693193fe847879d09e60525fc1e180eb94587025 Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 18:16:04 2021 +0200 Consistent error handling in codespaces API operations Using HandleHTTPError ensures that hints regarding insufficient OAuth scopes will be properly reported on stderr. commit 2c3f02ee62fe18e6472d6ff159ef24a4d42c1309 Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 17:30:05 2021 +0200 Ensure NOT_FOUND error when querying private repos using insufficient scope commit b0905a415f1bd17ad083130c739778e94e0af29a Merge: fccc9101 07fa60b6 Author: Jose Garcia <[email protected]> Date: Thu Oct 14 11:22:25 2021 -0400 Merge pull request #4508 from cli/jg/codespace-stop codespace stop: new command to stop a running codespace commit 0748e658ccdf5ff0f1f37a6ab758674630a2259f Author: Jose Garcia <[email protected]> Date: Thu Oct 14 11:07:25 2021 -0400 Switches port binding to 127.0.0.1 where possible commit fccc910166930abe63c6fab92655fc7b2af07a5a Merge: 53479c71 d68126af Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 16:15:42 2021 +0200 Merge pull request #4517 from cli/macos-firewall-prompt-skip Avoid macOS prompt to allow incoming connections in liveshare tests commit 5e56b4a7ceb04c78b3e9d4de859031b3e2cc53a8 Author: Jose Garcia <[email protected]> Date: Thu Oct 14 09:21:03 2021 -0400 Fix tests commit 3544275c2ff5588bc746fcf0091e4e2cc1b0b320 Author: Jose Garcia <[email protected]> Date: Thu Oct 14 09:10:15 2021 -0400 Implement new API payload for a Codespace commit d68126af9970a9e4f0e4c429f199fbfe4c42e9ac Author: Mislav Marohnić <[email protected]> Date: Thu Oct 14 14:23:36 2021 +0200 Avoid macOS prompt to allow incoming connections in liveshare tests Listening on the localhost interface disallows connections from the outside anyway, so the OS firewall doesn't have to prompt whether the user wants to allow incoming connections to the Go process. commit d72d0f47f617ac716a15348451b27f104e06031b Merge: 285f8659 53479c71 Author: nate smith <[email protected]> Date: Wed Oct 13 16:53:50 2021 -0500 Merge remote-tracking branch 'origin/trunk' into browse-commit commit 2ca18e0600223d8e2e8588a75cf693d17598fe43 Author: Mislav Marohnić <[email protected]> Date: Wed Oct 13 23:24:14 2021 +0200 Warn about missing OAuth scopes when reporting HTTP 4xx errors If a 4xx server response lists scopes in the X-Accepted-Oauth-Scopes header that are not present in the X-Oauth-Scopes header, the final error messaging on stderr will now include a hint for the user that they might need to request the additional scope: $ gh codespace list error getting codespaces: HTTP 403: Must have admin rights to Repository. (https://api.github.com/user/codespaces?per_page=30) This API operation needs the "codespace" scope. To request it, run: gh auth refresh -h github.com -s codespace commit 53479c712c6069ca7b5ce3cccf835c2e87689d15 Merge: d5c9630f 127e2dae Author: Mislav Marohnić <[email protected]> Date: Wed Oct 13 21:01:39 2021 +0200 Merge pull request #4510 from cli/dependabot-patch Configure Dependabot to only consider patch version bumps commit d5c9630faed73530cad87ac898c404fb463cb835 Merge: 9f1a1d88 3dbec865 Author: Jose Garcia <[email protected]> Date: Wed Oct 13 14:44:10 2021 -0400 Merge pull request #4511 from cli/jg/keepalive-fix codespace ssh: fix for nil logger on non-debugging scenarios commit 3dbec8655688b54df93918996c942963872fd5d4 Author: Jose Garcia <[email protected]> Date: Wed Oct 13 14:30:33 2021 -0400 PR Feedback commit d6b5157effdc923ab6d21655f8220a9d94e26f2e Author: Jose Garcia <[email protected]> Date: Wed Oct 13 14:15:26 2021 -0400 Fix for nil logger on non-debugging scenarios commit 9f1a1d88052b412126772eb813c7ae43c451f6d0 Merge: b9bdef2b cf80fbe5 Author: Mislav Marohnić <[email protected]> Date: Wed Oct 13 20:12:17 2021 +0200 Merge pull request #4509 from cli/downgrade-spinner Downgrade spinner package due to cleanup bug commit 127e2dae990aa3d7ecdcf056421f4388a7535ef3 Author: Mislav Marohnić <[email protected]> Date: Wed Oct 13 20:06:19 2021 +0200 Configure Dependabot to only consider patch version bumps https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#ignore commit b9bdef2b002e07b22e6f5e5e341612ae58c686b3 Author: Marwan Sulaiman <[email protected]> Date: Wed Oct 13 13:56:03 2021 -0400 Add org scoped port forwarding + fix test formatting (#4497) * Add org scoped port forwarding + fix test formatting * Redesign port visibility * Update pkg/cmd/codespace/ports.go Co-authored-by: Jose Garcia <[email protected]> * Change sub command to privacy * Example pr comment * Fix test mock * Fix test mock Co-authored-by: Jose Garcia <[email protected]> commit cf80fbe509efc6079d05827a556f152101cf31d7 Author: Mislav Marohnić <[email protected]> Date: Wed Oct 13 19:45:20 2021 +0200 Downgrade spinner package due to cleanup bug The spinner is not successfully visually cleaned up after calling its Stop method. https://github.com/briandowns/spinner/issues/123 commit 07fa60b69a6a47a60f270f13abdc37d5e5779aae Author: Jose Garcia <[email protected]> Date: Wed Oct 13 11:46:57 2021 -0400 PR Feedback commit a033b85fa294969ed2df0ed14dac7f7c4514cdd6 Merge: 12e5b942 97b52b30 Author: Jose Garcia <[email protected]> Date: Wed Oct 13 11:21:43 2021 -0400 Merge pull request #4461 from cli/jg/liveshare-keepalive codespace/liveshare keepalive: keep LS sessions alive with PF traffic commit be10950058cf45ccf8d5e8c7692e780aeb7fff90 Author: Jose Garcia <[email protected]> Date: Wed Oct 13 11:04:15 2021 -0400 Update mocks commit 12e5b9420557061d907948d1659185189faddc58 Merge: 675ee316 961cd57b Author: Mislav Marohnić <[email protected]> Date: Wed Oct 13 16:58:36 2021 +0200 Merge pull request #4507 from alefranz/patch-1 Update winget installation instructions commit 4fb4a21efd0f3e2383d6dd3657067ba450c8430c Author: Jose Garcia <[email protected]> Date: Wed Oct 13 10:57:50 2021 -0400 Rename + docs commit 97b52b30fca88bfe6bd46b3bbc116977aaa5b806 Merge: 5170a293 675ee316 Author: Jose Garcia <[email protected]> Date: Wed Oct 13 10:45:40 2021 -0400 Merge branch 'trunk' of github.com:cli/cli into jg/liveshare-keepalive commit 961cd57b8783837a054836af53d21e19b9d38137 Author: Alessio Franceschelli <[email protected]> Date: Wed Oct 13 15:01:50 2021 +0100 Update winget installation instructions commit 675ee316e9727a1d9822ba68a0565c45bffab461 Merge: aa227079 9302e68c Author: Alan Donovan <[email protected]> Date: Wed Oct 13 09:00:37 2021 -0400 Merge pull request #4504 from cli/show-http-status cs create: include HTTP status code in error from /user/codespaces/*/start commit aa2270799ca0357618d30222f9f3368dcc714ced Merge: 968b093e 77a86e86 Author: Jose Garcia <[email protected]> Date: Wed Oct 13 08:29:11 2021 -0400 Merge pull request #4505 from cli/jg/fix-connection codespace: fix for API response body change commit 77a86e8611eeb9c7681dda49a7d36ed9ce520d67 Author: Jose Garcia <[email protected]> Date: Wed Oct 13 08:07:59 2021 -0400 Fix for API response body change - Connection is now embedded within the top level of the Codespace payload instead of inside the environment. commit ea0d0a543faa50c4e57eea019f09c6b64a9921bd Author: Jose Garcia <[email protected]> Date: Wed Oct 13 07:45:54 2021 -0400 Initial StopCodespace implementation - API - Command commit 9302e68c92eeb2687c169c9a84d574df2e5e7053 Author: Alan Donovan <[email protected]> Date: Wed Oct 13 07:00:55 2021 -0400 Include HTTP status code in error commit defbf0f306b665bf86847ff5d704df2a8addd308 Author: Sam Coe <[email protected]> Date: Tue Oct 5 11:17:35 2021 -0700 Make extension upgrade output more friendly commit 968b093eda2c9c18a41ed9150546f7e0820451ed Merge: 7abf682e ed342797 Author: Sam <[email protected]> Date: Tue Oct 12 15:53:51 2021 -0700 Merge pull request #4396 from cli/speedy-extension-list Use concurrency to check for extension updates commit 5170a2931f9cd8378fafeba89cab1db014a2de43 Author: Jose Garcia <[email protected]> Date: Tue Oct 12 15:45:05 2021 -0400 Switch to standard lib log.Logger & support dfile - --debug-file flag can now be used in conjuction with --debug to specify the debug file path - Push out logger concerns to callers of liveshare commit 7abf682e26d4619c9639e6b1ece8d5b810e0bf04 Merge: efd0b677 2819deb1 Author: Mislav Marohnić <[email protected]> Date: Tue Oct 12 18:56:24 2021 +0200 Merge pull request #4480 from cli/codeql-dependabot CodeQL-Dependabot compatibility commit ed3427974c1746c15f7873cd89688beea897855b Author: Sam Coe <[email protected]> Date: Thu Sep 30 08:10:42 2021 -0700 Use concurrency to check for extension updates commit efd0b677ef515dbec2b667cfdf456be380a962df Merge: ec554822 5fd9f68c Author: Mislav Marohnić <[email protected]> Date: Tue Oct 12 17:27:29 2021 +0200 Merge pull request #4496 from cli/dependabot/go_modules/github.com/gabriel-vasile/mimetype-1.4.0 Bump github.com/gabriel-vasile/mimetype from 1.1.2 to 1.4.0 commit 5fd9f68c85072f5c6356ea605a07dbacd75422ff Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 12 14:35:16 2021 +0000 Bump github.com/gabriel-vasile/mimetype from 1.1.2 to 1.4.0 Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype) from 1.1.2 to 1.4.0. - [Release notes](https://github.com/gabriel-vasile/mimetype/releases) - [Commits](https://github.com/gabriel-vasile/mimetype/compare/v1.1.2...v1.4.0) --- updated-dependencies: - dependency-name: github.com/gabriel-vasile/mimetype dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> commit ec554822b81d3f26095ef6b4eff10ce7cc2f8174 Author: Parth <[email protected]> Date: Tue Oct 12 06:48:40 2021 -0400 Add repo archive command (#4410) Co-authored-by: meiji163 <[email protected]> commit cedbbe3c2ae569f0f7a011b83930a1930145ee5a Author: Mateusz Urbanek <[email protected]> Date: Mon Oct 11 19:32:40 2021 +0100 Add limit flag to codespace list (#4453) Co-authored-by: Mislav Marohnić <[email protected]> commit 4d274bd24e3288c9f97bb1934b5c2da440689ac0 Merge: 3956510c adc30723 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 18:30:57 2021 +0200 Merge pull request #4485 from cli/dependabot/go_modules/github.com/creack/pty-1.1.16 Bump github.com/creack/pty from 1.1.13 to 1.1.16 commit 3956510cbca7c0bb012fa0b959cf219c6a1a4c59 Merge: af522e4e c20a5c28 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 18:25:59 2021 +0200 Merge pull request #4484 from cli/dependabot/go_modules/github.com/hashicorp/go-version-1.3.0 Bump github.com/hashicorp/go-version from 1.2.1 to 1.3.0 commit af522e4e69ed4fc8f7534eb801c2967752afd97c Merge: a364cd34 32c17b2d Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 18:25:23 2021 +0200 Merge pull request #4482 from cli/dependabot/go_modules/github.com/itchyny/gojq-0.12.5 Bump github.com/itchyny/gojq from 0.12.4 to 0.12.5 commit adc3072303450db0643c7eec9ab00f941aca1cb8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 16:24:32 2021 +0000 Bump github.com/creack/pty from 1.1.13 to 1.1.16 Bumps [github.com/creack/pty](https://github.com/creack/pty) from 1.1.13 to 1.1.16. - [Release notes](https://github.com/creack/pty/releases) - [Commits](https://github.com/creack/pty/compare/v1.1.13...v1.1.16) --- updated-dependencies: - dependency-name: github.com/creack/pty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> commit a364cd34875c2d5c0bc5412ace9a50b4b6923df8 Merge: 152c2888 8cc77bd6 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 18:12:32 2021 +0200 Merge pull request #4483 from cli/dependabot/go_modules/github.com/cpuguy83/go-md2man/v2-2.0.1 Bump github.com/cpuguy83/go-md2man/v2 from 2.0.0 to 2.0.1 commit 8cc77bd61ee6918217377b286f70afcc9ad5bbe9 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 18:05:52 2021 +0200 Fix test expectation for man contents https://github.com/cpuguy83/go-md2man/pull/74 commit 32c17b2d9538c7005acfe8c99c5a40775e3f888d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 15:29:21 2021 +0000 Bump github.com/itchyny/gojq from 0.12.4 to 0.12.5 Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.12.4 to 0.12.5. - [Release notes](https://github.com/itchyny/gojq/releases) - [Changelog](https://github.com/itchyny/gojq/blob/main/CHANGELOG.md) - [Commits](https://github.com/itchyny/gojq/compare/v0.12.4...v0.12.5) --- updated-dependencies: - dependency-name: github.com/itchyny/gojq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> commit 152c2888d7e41ce6050eb8e4b7a9708694500e80 Merge: 9406ba3a a131644d Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 17:23:35 2021 +0200 Merge pull request #4481 from cli/dependabot/go_modules/github.com/mattn/go-colorable-0.1.11 Bump github.com/mattn/go-colorable from 0.1.8 to 0.1.11 commit c20a5c28327965600e78356a7c86241a016f0c22 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 14:25:33 2021 +0000 Bump github.com/hashicorp/go-version from 1.2.1 to 1.3.0 Bumps [github.com/hashicorp/go-version](https://github.com/hashicorp/go-version) from 1.2.1 to 1.3.0. - [Release notes](https://github.com/hashicorp/go-version/releases) - [Changelog](https://github.com/hashicorp/go-version/blob/master/CHANGELOG.md) - [Commits](https://github.com/hashicorp/go-version/compare/v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-version dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> commit 668d7dc8ffe086e5f7bf3ed6c043ebc328fbba66 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 14:25:26 2021 +0000 Bump github.com/cpuguy83/go-md2man/v2 from 2.0.0 to 2.0.1 Bumps [github.com/cpuguy83/go-md2man/v2](https://github.com/cpuguy83/go-md2man) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cpuguy83/go-md2man/releases) - [Commits](https://github.com/cpuguy83/go-md2man/compare/v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cpuguy83/go-md2man/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> commit a131644d858c2204ac740e6f617d65d82f43fe1c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 14:25:14 2021 +0000 Bump github.com/mattn/go-colorable from 0.1.8 to 0.1.11 Bumps [github.com/mattn/go-colorable](https://github.com/mattn/go-colorable) from 0.1.8 to 0.1.11. - [Release notes](https://github.com/mattn/go-colorable/releases) - [Commits](https://github.com/mattn/go-colorable/compare/v0.1.8...v0.1.11) --- updated-dependencies: - dependency-name: github.com/mattn/go-colorable dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> commit 9406ba3abcb5bb983222b1c36c14ade0bc92bd19 Merge: 5dcd1dd5 30187708 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 11:49:51 2021 +0200 Merge pull request #4478 from cli/dependabot/go_modules/github.com/mattn/go-isatty-0.0.14 Bump github.com/mattn/go-isatty from 0.0.13 to 0.0.14 commit 5dcd1dd5b1b74bc0461ad5a5515c991a1687997b Merge: 74ddc24d b3947a7a Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 11:49:18 2021 +0200 Merge pull request #4477 from cli/dependabot/go_modules/github.com/briandowns/spinner-1.16.0 Bump github.com/briandowns/spinner from 1.11.1 to 1.16.0 commit 3018770846358d6dc552109fb56975d9a8c1e253 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 09:43:40 2021 +0000 Bump github.com/mattn/go-isatty from 0.0.13 to 0.0.14 Bumps [github.com/mattn/go-isatty](https://github.com/mattn/go-isatty) from 0.0.13 to 0.0.14. - [Release notes](https://github.com/mattn/go-isatty/releases) - [Commits](https://github.com/mattn/go-isatty/compare/v0.0.13...v0.0.14) --- updated-dependencies: - dependency-name: github.com/mattn/go-isatty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> commit 74ddc24dac67ac85309a5c73cd874a332f0f5199 Merge: fd16453e e472f460 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 11:38:02 2021 +0200 Merge pull request #4479 from cli/dependabot/go_modules/github.com/muesli/termenv-0.9.0 Bump github.com/muesli/termenv from 0.8.1 to 0.9.0 commit 2819deb15b6770fc2dd6f24fc6fa8ef89956ce86 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 11:33:44 2021 +0200 Avoid applying human-oriented PR automation to PRs from bots commit dabaa5ad7ddde85b455ea21c94bc11388dfaed83 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 11:17:48 2021 +0200 CodeQL-Dependabot compatibility Configure the CodeQL workflow to avoid running for pushes on all pull requests because that causes problems with Dependabot PRs. https://github.com/cli/cli/pull/4475/checks?check_run_id=3857074760 commit fd16453eb6fbae2305376308a5b66da314e380d8 Merge: 31cca114 98fa94cc Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 11:21:36 2021 +0200 Merge pull request #4475 from cli/dependabot/go_modules/github.com/google/go-cmp-0.5.6 Bump github.com/google/go-cmp from 0.5.5 to 0.5.6 commit e472f46083fecdca5a40f1c7578cd0ab31e4b0b2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 08:54:27 2021 +0000 Bump github.com/muesli/termenv from 0.8.1 to 0.9.0 Bumps [github.com/muesli/termenv](https://github.com/muesli/termenv) from 0.8.1 to 0.9.0. - [Release notes](https://github.com/muesli/termenv/releases) - [Commits](https://github.com/muesli/termenv/compare/v0.8.1...v0.9.0) --- updated-dependencies: - dependency-name: github.com/muesli/termenv dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> commit b3947a7a94fe4c25c466ef419a64b332b49e4f97 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 08:54:15 2021 +0000 Bump github.com/briandowns/spinner from 1.11.1 to 1.16.0 Bumps [github.com/briandowns/spinner](https://github.com/briandowns/spinner) from 1.11.1 to 1.16.0. - [Release notes](https://github.com/briandowns/spinner/releases) - [Commits](https://github.com/briandowns/spinner/compare/v1.11.1...v1.16.0) --- updated-dependencies: - dependency-name: github.com/briandowns/spinner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> commit 98fa94cc6b15c1793dfb9aa6ee6601ee699d3f1d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Oct 11 08:53:52 2021 +0000 Bump github.com/google/go-cmp from 0.5.5 to 0.5.6 Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.5 to 0.5.6. - [Release notes](https://github.com/google/go-cmp/releases) - [Commits](https://github.com/google/go-cmp/compare/v0.5.5...v0.5.6) --- updated-dependencies: - dependency-name: github.com/google/go-cmp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> commit 31cca1145f3e8e0e14bf39b2b49850faecd2cbd4 Merge: 0c5c2378 706dede7 Author: Mislav Marohnić <[email protected]> Date: Mon Oct 11 10:48:22 2021 +0200 Merge pull request #4473 from neil465/neil/dependabot Enable dependabot to get security updates and if needed version updat… commit 706dede7acfee08c2b4f09d9ab64f81bdb197d72 Author: flying-cow <[email protected]> Date: Sun Oct 10 19:41:30 2021 -0500 Enable dependabot to get security updates and if needed version updates on dependencies https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically Having knowledge about vulnerabilities of the dependencies helps the project owners decide on their dependencies security posture to make decisions. If the project decides to get updates only on security updates and not on any version updates then setting these options would not open any PR 's open-pull-requests-limit: 0 commit 0c5c2378ac540f07700dd87b55bbb3313a728ca2 Merge: 79832c1b e4c8aa3b Author: Mislav Marohnić <[email protected]> Date: Fri Oct 8 13:58:56 2021 +0200 Merge pull request #4460 from m4ver1k/feat/2720 #2720 | Add patch flag to pull-request diff command commit e4c8aa3b2bb50ee2f41f307eacf5b2026ef6911e Author: Mislav Marohnić <[email protected]> Date: Fri Oct 8 13:53:19 2021 +0200 Add tests for `pr diff --patch` commit 79832c1b04ad0d0a01897c1f5992bbefde44d584 Author: Luciano Zago <[email protected]> Date: Fri Oct 8 06:14:49 2021 -0300 Add instructions to gh installation via spack (#4412) commit 1aefc7437834522f1bd1fbc3c1f7ff5cbf7fa801 Author: Jose Garcia <[email protected]> Date: Thu Oct 7 16:48:09 2021 -0400 Add more time between events commit 1ff58a3de734f93351111775e64a7fafd99cb683 Author: Jose Garcia <[email protected]> Date: Thu Oct 7 16:39:43 2021 -0400 Update docs, remove needless condition check commit 97cbdca84a2e11f1d249cf34d2760ebf5c7a3faa Author: Jose Garcia <[email protected]> Date: Thu Oct 7 15:45:55 2021 -0400 Fix additional race in tests commit 8a559ee12a0cd4b564b68564a0aef803c69f3d87 Author: Jose Garcia <[email protected]> Date: Thu Oct 7 15:38:16 2021 -0400 Fix unrelated tests commit 2406f3f09a0d618a5d442e5b34b09dbd25adbaad Author: Jose Garcia <[email protected]> Date: Thu Oct 7 15:32:07 2021 -0400 Fix races and remove unreachable code commit 7ba2fb4c0ed1a376dbb2cf76d2bfd6f6c810cc7a Author: Jose Garcia <[email protected]> Date: Thu Oct 7 15:19:14 2021 -0400 Make fileLogger more versatile commit 8f5d6bb672e889ed8723a7f5bbc22da1c0a9ef12 Author: Jose Garcia <[email protected]> Date: Thu Oct 7 15:14:42 2021 -0400 Tests for most of the new behavior - Made the heartbeat interval configurable for easier testing - Moved span to the top of connect to capture the full execution commit e0897fd8e8ba9ec370b1710fe21719aa457516a5 Author: Adarsh K Kumar <[email protected]> Date: Thu Oct 7 23:09:21 2021 +0530 #2720 | Add patch flag to pull-request diff command commit 9c8351ecd82caa1e83af78255a71e24d60b2ddf9 Merge: 55f4fcf0 cff6cf9a Author: Jose Garcia <[email protected]> Date: Thu Oct 7 11:10:45 2021 -0400 Merge branch 'trunk' of github.com:cli/cli into jg/liveshare-keepalive commit cff6cf9acf68ba4560da657cb40f34df7a07748e Merge: becc45a1 400749d5 Author: Jose Garcia <[email protected]> Date: Thu Oct 7 11:09:26 2021 -0400 Merge pull request #4457 from cli/jg/fix-create-regression codespace create: fix regression returning nil codespace commit 400749d560caf6ed7f8cc9e9a11923ea32bbd8fa Author: Jose Garcia <[email protected]> Date: Thu Oct 7 11:01:24 2021 -0400 Fix regression returning nil codespace commit 55f4fcf05c51896a98e6223615a4faaf4210e0b6 Author: Jose Garcia <[email protected]> Date: Thu Oct 7 10:42:06 2021 -0400 Live Share session activity detection - Session now accepts two new options: ClientName and Logger - Port forwarder now supports a keepAlive parameter which when true, instructs the PF to call the session's keepAlive method. - Port forwarder uses a new traffic monitor to detect I/O traffic and notify the session when applicable. - The SSH command introduces a new debug flag which enables the command to log to a new temporary file. The file path is printed to the user. commit becc45a1df4bfd16adf5f46e45e3d46551a4bd48 Merge: cd1eec5e 8f5806d6 Author: Sam <[email protected]> Date: Wed Oct 6 12:54:25 2021 -0700 Merge pull request #4437 from cli/fix-extension-io-bug Set io when initializing extension manager commit cd1eec5e38e4a47ee507233d18a44e3ac81ddf1c Merge: 6f978dd8 073200a2 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 13:55:56 2021 -0400 Merge pull request #4448 from cli/jg/codeowners Add codeowners commit 6f978dd8a4e6f11e33fa5530297ad29e22b11445 Merge: 3d0d95ce b44474c3 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 13:55:45 2021 -0400 Merge pull request #4440 from cli/jg/choose-codespace-prompt codespace: choose codespace prompt improvements commit b44474c32b1e2e155aacce3e812d56ebd0ea8159 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 13:47:20 2021 -0400 Revert rename for ports cmd commit bdc9ad30e765c05913245247a44fcd3f8c573a13 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 13:46:04 2021 -0400 Revert other rename changes commit 811d841fae35c7555854560014419d2ab9c6fa46 Merge: 771ac714 3d0d95ce Author: Jose Garcia <[email protected]> Date: Wed Oct 6 13:40:01 2021 -0400 Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt commit 3d0d95ce2b95917089035326db885ffd995ab128 Merge: 52e16dfe 20ae9d30 Author: Gabriel Ramírez <[email protected]> Date: Wed Oct 6 12:38:50 2021 -0500 Merge pull request #4439 from geramirez/geramirez/codespaces-pagination Adding pagination to list codespaces commit 771ac714ac955451c3c917ea6bbf43f8d126ec3e Author: Jose Garcia <[email protected]> Date: Wed Oct 6 11:47:18 2021 -0400 Update docs commit a509c2d88487c05d5ac84f781536e8dbd08e8543 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 11:45:43 2021 -0400 Remove unused guid commit 3a2864363035720e9c1da0371abab2f4c4847176 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 11:44:26 2021 -0400 Keep codespace struct in API for now - Use a private codespace structure in the cmd pkg to encapsulate common behavior commit 20ae9d305d13746c5691611686a21168266dafba Author: Gabriel Ramírez <[email protected]> Date: Wed Oct 6 14:53:55 2021 +0000 Fetch 100 codespaces by default commit 073200a275b97ed1cd0f9da6927c74dfe341efce Author: Jose Garcia <[email protected]> Date: Wed Oct 6 10:19:17 2021 -0400 Add codeowners commit e29a0ac7c464b5493766ee5843fa73f3cb87e9d3 Merge: 34f9c0a6 237fdd40 Author: Gabriel Ramírez <[email protected]> Date: Wed Oct 6 14:18:57 2021 +0000 Merge branch 'geramirez/codespaces-pagination' of https://github.com/geramirez/cli into geramirez/codespaces-pagination commit 34f9c0a67c201f98ddde69f26794d1b2bf54539c Author: Gabriel Ramírez <[email protected]> Date: Wed Oct 6 14:18:44 2021 +0000 Updating docs and interation exit condition to not check the final page commit 237fdd40c8773f87039b80b651fea840eb0e54c0 Author: Gabriel Ramírez <[email protected]> Date: Wed Oct 6 09:03:49 2021 -0500 Update internal/codespaces/api/api.go Co-authored-by: Jose Garcia <[email protected]> commit 017632d63d398dfcb5d150c3e51760f93be8f07c Merge: 7fe8357d 52e16dfe Author: Jose Garcia <[email protected]> Date: Wed Oct 6 09:57:39 2021 -0400 Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt commit 52e16dfe094fff85b684930fe377b3b363e63278 Merge: 616d6c2d b2ff4c32 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 09:41:01 2021 -0400 Merge pull request #4446 from cli/jg/get-codespace-api codespace: switch `API.GetCodespace` to new API endpoint commit b2ff4c321a942539ad5dd4931c1e64738c05db34 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 09:25:39 2021 -0400 Remove unused structs commit 7c497f283b06d9e2e1bff145d6a0b7edf4b3616a Author: Jose Garcia <[email protected]> Date: Wed Oct 6 09:15:07 2021 -0400 Update test signature commit 8bb55359b1f9b7a9a97f0d8d162d3d9b3717d7a1 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 09:10:00 2021 -0400 Update mock API commit 8135fdbd993270690702e06a233440038c087d22 Author: Jose Garcia <[email protected]> Date: Wed Oct 6 08:50:42 2021 -0400 Switch GetCodespace to new API endpoint - Drop GetCodespaceToken as it is no longer necessary - Introduces new behavior with the API to optionally include connection details in the GET request. Ommitting to do so results in a faster response commit aa49a3a5571e78eddb49a90a833ffb74bc76da5b Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 21:43:28 2021 +0000 Adding a second condition just in case commit 61b0fe36b2f354967ee6a009e9b744737ef113ed Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 21:31:47 2021 +0000 Adding additional tests for mid-flight deletions and additions commit 02145cc4fd27cd619da298208846982e85203f7a Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 21:15:24 2021 +0000 Updated PR with suggestions - created a new method to avoid defer pileup issue - removed extra api call at the end of the sequence commit c6dc50983dc9d9c1d441797d74443397506c0c66 Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 15:33:22 2021 -0500 Update internal/codespaces/api/api.go Co-authored-by: Jose Garcia <[email protected]> commit 4314f734e30ff4ceb0bd67834527c1cf8d53044a Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 15:33:16 2021 -0500 Update internal/codespaces/api/api.go Co-authored-by: Jose Garcia <[email protected]> commit e793a5961d4b400ec122391e21f77e663ac47225 Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 19:00:21 2021 +0000 Add strconv commit fd5894d28defa0d92a98bf8f66c837bfaeb7709c Merge: 409cd9c3 616d6c2d Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 18:58:23 2021 +0000 Merge remote-tracking branch 'upstream/trunk' into geramirez/codespaces-pagination commit 409cd9c388976b4025bb929684d8fb034eb9ef52 Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 18:49:41 2021 +0000 Fixing Has() issue due to go version commit 7fe8357d40883f2d6294197bb53b428320fcb401 Author: Jose Garcia <[email protected]> Date: Tue Oct 5 13:30:17 2021 -0400 Better short name commit 1971292175011112e461240f64ff93131e288c24 Author: Jose Garcia <[email protected]> Date: Tue Oct 5 13:24:47 2021 -0400 Fixes bug there are +2 codespaces with a conflict - Tracks conflicting name going forward for other records - Moves the git status dirty star into a constant so we can reference it commit a8d1718f21603511ff3b248f11df067b77355591 Merge: 975bd7c0 616d6c2d Author: Jose Garcia <[email protected]> Date: Tue Oct 5 12:57:11 2021 -0400 Merge branch 'trunk' of github.com:cli/cli into jg/choose-codespace-prompt commit 777978644c348eaaaeb3b208412baee90cf70b2c Author: Gabriel Ramírez <[email protected]> Date: Tue Oct 5 16:49:40 2021 +0000 Adding pagination to list codespaces commit 616d6c2db122eda1241dc9f10cc68e3873a79237 Merge: 3652307c e0db10e4 Author: Jose Garcia <[email protected]> Date: Tue Oct 5 12:44:38 2021 -0400 Merge pull request #4431 from cli/jg/get-skus-public codespace machine: switch `API.GetCodespacesMachines` to use new API commit 8f5806d61ffb6508a65a7d4630e125ce6da31892 Author: Sam Coe <[email protected]> Date: Tue Oct 5 09:10:49 2021 -0700 Set io when initializing extension manager commit 975bd7c08a459c2f26ffd6dc2998c05793710f2a Author: Jose Garcia <[email protected]> Date: Tue Oct 5 11:23:12 2021 -0400 Change choose codespace prompt - Repo + branch is favored - Codespace name is included to disambiguate between two codespaces - Move Codespace model out of out API into its own package - Update call sites and group behavior under codespace.Codespace commit 3652307cf3c6a8a48711e7c28a7b8cf6c9dcb1a3 Merge: a2e6df18 a3efb53c Author: Jose Garcia <[email protected]> Date: Tue Oct 5 09:20:33 2021 -0400 Merge pull request #4429 from cli/jg/start-codespace-public codespace create: update `API.StartCodespace` to use new API endpoint commit a2e6df18e72c2bee6e3af3ef729c671c83a81587 Merge: 50d8f1e0 d02876e6 Author: Jose Garcia <[email protected]> Date: Tue Oct 5 08:23:36 2021 -0400 Merge pull request #4432 from cli/jg/rename-pkg codespace: rename the cmd pkg to codespace commit 50d8f1e09ab61e64733a13cda446aaf27148fbfd Merge: 93cea6d3 61af29bb Author: Jose Garcia <[email protected]> Date: Tue Oct 5 08:20:53 2021 -0400 Merge pull request #4409 from cli/jg/delete-codespace-public codespace delete: update DeleteCodespaces to new API endpoint commit d02876e6ea3cc0ad12437cd5ecd684e9d0d226ca Author: Jose Garcia <[email protected]> Date: Mon Oct 4 14:16:04 2021 -0400 Rename the cmd pkg to codespace commit e0db10e4dd72c02e1c3b820661c50a766d7defd8 Author: Jose Garcia <[email protected]> Date: Mon Oct 4 13:40:18 2021 -0400 Switch API.GetCodespacesMachines to use new API - The SKU terminology is also dropped in favor of "machine" which matches the nomenclature of the rest of the product. commit a3efb53c443d07dfab92a2dae7d66073d6e47124 Author: Jose Garcia <[email protected]> Date: Mon Oct 4 08:32:02 2021 -0400 Update API.StartCodespace to use new API endpoint - Switch to using name instead of GUID - Remove GUID from the code since it is not used anywhere else - Add docs to the api client methods - Re-gen mocked client commit 61af29bb968ad77a654f3db68ae67c21e949a238 Author: Jose Garcia <[email protected]> Date: Fri Oct 1 13:02:29 2021 -0400 Update telemetry path commit 93cea6d370992d4dc0bfc9206389d199ce196ac4 Merge: 68e54a59 86a4706e Author: Jose Garcia <[email protected]> Date: Fri Oct 1 12:55:44 2021 -0400 Merge pull request #4408 from cli/jg/create-codespace-public codespace create: update startCreate to use new API endpoint commit 6b1876161d696629bdf8e2e0d8c34951313fb8c9 Author: Jose Garcia <[email protected]> Date: Fri Oct 1 12:53:35 2021 -0400 Update DeleteCodespaces to new API endpoint - Drop the need for the user argument - Update mocks - Remove no longer applicable TODO comment - Show message for successful deletion (this regressed) commit 86a4706ed224c0368de114ced339c9fef7fc41f6 Author: Jose Garcia <[email protected]> Date: Fri Oct 1 11:29:16 2021 -0400 Update startCreate to use new API endpoint - Updates the signature of startCreate - Can't update API.CreateCodespace just yet until we support expanded access on the GET codespace endpoint which is used for polling commit 68e54a5904297cfb433306bc06871fdb4aab2bde Merge: cb6db95e 05297b8c Author: Jose Garcia <[email protected]> Date: Fri Oct 1 11:28:37 2021 -0400 Merge pull request #4407 from cli/jg/list-codespaces-public codespace list: update ListCodespaces to use new API endpoint commit cb6db95ec6fd7fa72bd76df2f9e56bd0bf6a2ff8 Merge: 77e8b16b a7238130 Author: Mislav Marohnić <[email protected]> Date: Fri Oct 1 17:26:04 2021 +0200 Merge pull request #4403 from cli/cs-concurrent-requests Don't allow the lazyLoadedHTTPClient mutex to wrap `Do()` commit 05297b8c8d899ce9491be9e14d33f8472d22f011 Author: Jose Garcia <[email protected]> Date: Fri Oct 1 10:37:15 2021 -0400 Update ListCodespaces to use new API endpoint - Removes the need for a User to list codespaces which should result in a slight speed improvement. commit 77e8b16b27330d51bf3a836f0ac581bf6beecae3 Merge: be22cabe 6249bee1 Author: Mislav Marohnić <[email protected]> Date: Fri Oct 1 14:20:37 2021 +0200 Merge pull request #4405 from cli/bump-survey Bump Survey to fix "Unexpected escape sequence" commit 6249bee148f1c1a900dc9c00d1849a8dd622de3a Author: Mislav Marohnić <[email protected]> Date: Fri Oct 1 14:11:15 2021 +0200 Bump Survey to fix "Unexpected escape sequence" https://github.com/AlecAivazis/survey/pull/367 commit a7238130643528bfb29499db8853cae73640788c Author: Mislav Marohnić <[email protected]> Date: Fri Oct 1 11:18:15 2021 +0200 Don't allow the lazyLoadedHTTPClient mutex to wrap `Do()` We only need a mutex around accessing `l.httpClient`, but never around the actual HTTP request. commit be22cabe0b789ee11d4964817a518a5a53982b9c Merge: ab27d1b5 0859de01 Author: Jose Garcia <[email protected]> Date: Thu Sep 30 12:49:50 2021 -0400 Merge pull request #4395 from cli/jg/move-ghcs-cmd pkg/cmd/codespace: move `cmd/ghcs` to `pkg/cmd/codespace` commit 0859de0124c7914d854565505058bb50a069f76c Merge: 9e6c11e7 ab27d1b5 Author: Jose Garcia <[email protected]> Date: Thu Sep 30 12:38:41 2021 -0400 Merge branch 'trunk' of github.com:cli/cli into jg/move-ghcs-cmd commit ab27d1b5e12ddf6e9a6a137b780616a9290eff41 Merge: 4e9c443a 94953ed3 Author: Jose Garcia <[email protected]> Date: Thu Sep 30 12:02:14 2021 -0400 Merge pull request #4394 from cli/jg/move-codespace-api codespace api: move `internal/api` to `internal/codespaces/api` commit 94953ed3fcd9cc83dadef201216420a1806dcdea Merge: 23d41ddb 4e9c443a Author: Jose Garcia <[email protected]> Date: Thu Sep 30 11:52:22 2021 -0400 Merge branch 'trunk' of github.com:cli/cli into jg/move-codespace-api commit 4e9c443adf64452a94073a903e17b8cc906622a9 Merge: 877ad22d 53e4149c Author: Jose Garcia <[email protected]> Date: Thu Sep 30 11:50:07 2021 -0400 Merge pull request #4393 from cli/jg/move-liveshare liveshare: move location from `internal/liveshare` to `pkg/liveshare` commit 9e6c11e767cb0a0d2ca8fcfe4508e0e819891ba5 Author: Jose Garcia <[email protected]> Date: Thu Sep 30 11:20:13 2021 -0400 Move `cmd/ghcs` to `pkg/cmd/codespace` - Delete pkg/cmd/codespace/main as it is no longer needed in this codebase commit 23d41ddb0d0e204a6816e51d4a296ae68fd360bd Author: Jose Garcia <[email protected]> Date: Thu Sep 30 11:09:59 2021 -0400 Format files commit b5bbb442fd61dae0581ae1758958a0d943181bcf Author: Jose Garcia <[email protected]> Date: Thu Sep 30 11:06:43 2021 -0400 Move `internal/api` to `internal/codespaces/api` commit 53e4149c91711fdfac59ddb40566816936a48a9a Author: Jose Garcia <[email protected]> Date: Thu Sep 30 10:42:03 2021 -0400 Update tests commit f4a5f82312377b267762f923af625933c7d00a51 Author: Jose Garcia <[email protected]> Date: Thu Sep 30 10:34:27 2021 -0400 Move internal/liveshare to pkg/liveshare commit 877ad22da6b4dfddff584125c0349218ff3e16e3 Merge: c4ec0a65 a1e72af1 Author: Jose Garcia <[email protected]> Date: Thu Sep 30 09:44:29 2021 -0400 Merge pull request #4384 from cli/import-codespaces Import codespaces commit a1e72af1dad5df202fba73cb3e0890620310ba68 Merge: c3ce95ea 2ce14f60 Author: Jose Garcia <[email protected]> Date: Thu Sep 30 09:26:28 2021 -0400 Merge pull request #4392 from cli/jg/validate-host-key codespace: validate host public keys commit 2ce14f603f0a944fbbc857193da7e916a22dd209 Author: Jose Garcia <[email protected]> Date: Thu Sep 30 08:40:18 2021 -0400 Update tests with mock public key and test case commit 5b5c3da39382927a1568f6a0a563f1454623b42e Author: Jose Garcia <[email protected]> Date: Thu Sep 30 08:16:28 2021 -0400 Validate host public keys commit c4ec0a65bace0d47067ef671fd2980b3c565aeef Merge: af812e2b 9e3893e1 Author: Mislav Marohnić <[email protected]> Date: Thu Sep 30 12:01:47 2021 +0200 Merge pull request #4363 from RasmusWL/patch-1 Also set `pushRemote` on `gh pr checkout` from fork commit af812e2bdcb59b781c2384013252463145ebbe74 Merge: 425bc648 7efd06b8 Author: Nate Smith <[email protected]> Date: Wed Sep 29 16:03:05 2021 -0500 Merge pull request #4373 from cli/ext-bin-upgrade binary extensions list & upgrade commit c3ce95ea1c140297122812b3aa87a831cc291ff0 Author: Jose Garcia <[email protected]> Date: Wed Sep 29 16:45:51 2021 -0400 Add mutex to guard httpClient commit 0d0152b0fab46ca3c54032673c95f3d670d1f063 Author: Mislav Marohnić <[email protected]> Date: Wed Sep 29 21:21:16 2021 +0200 Have `gh codespace` inherit the correct API client commit 7efd06b87dd5210cbb079c377fff08c0ae75c8aa Author: vilmibm <[email protected]> Date: Wed Sep 29 13:43:37 2021 -0500 rename function commit a2e7eaf80878e12f23edde21bfb054a44af23e52 Author: vilmibm <[email protected]> Date: Wed Sep 29 13:38:57 2021 -0500 test update available for binary ext in list commit 9bc50f5ab8cc8e7d08ba601e78d5dc1e8baeb7df Merge: 76736228 48bac0ab Author: Jose Garcia <[email protected]> Date: Wed Sep 29 10:49:30 2021 -0400 Merge pull request #4379 from cli/import-codespaces-add-nacl Switch to using cli/crypto & test fixes commit 48bac0abd2f7fcc5cbed5d48038f7e4307401eb7 Author: Mislav Marohnić <[email protected]> Date: Wed Sep 29 13:54:04 2021 +0200 Fix race in codespaces delete test commit a0f11b66643cefc50a6cacee3bb085a92316f706 Author: Jose Garcia <[email protected]> Date: Tue Sep 28 16:29:45 2021 -0400 Handle concurrency in tests and logger - Live Share tests - Logger implementation for ghcs commit 0e98b3065106cc5fdecde02609a957066c8f5647 Author: Jose Garcia <[email protected]> Date: Tue Sep 28 12:54:06 2021 -0400 Remove internal crypto pkg in favor of fork commit ef087123544b57251dcff77b5b7a760556af9433 Author: vilmibm <[email protected]> Date: Tue Sep 28 19:27:21 2021 -0500 test list commit 3971df4f93b6b7a9eefe6e27cf22c1e51bed8870 Author: vilmibm <[email protected]> Date: Tue Sep 28 19:23:28 2021 -0500 switch to stubBinaryExtension commit 392460b81e4445962c57b988d5e9ffce8ffcf598 Author: vilmibm <[email protected]> Date: Tue Sep 28 15:45:49 2021 -0500 WIP switching to stubBinaryExtension commit 541ed3ba6fb06ba6826c8c60d8f0ff81b99cd43d Author: vilmibm <[email protected]> Date: Tue Sep 28 15:33:11 2021 -0500 test Upgrade with binary exts commit 22c1778b9f1e443b107c8f342fc7d518d9c24a0e Author: vilmibm <[email protected]> Date: Tue Sep 28 15:04:45 2021 -0500 TODOs commit 94778a9cb05013c7cb9813b536a5e57c283879a5 Author: vilmibm <[email protected]> Date: Tue Sep 28 15:04:39 2021 -0500 un-stupid the file mode commit 1fe49fa77682090237f5f422d9ec4634f0109c19 Author: vilmibm <[email protected]> Date: Mon Sep 27 16:23:31 2021 -0500 fix listing, cleanup commit 54ec5329c5ad00e57151481182e210ac869176bd Author: vilmibm <[email protected]> Date: Wed Sep 22 16:37:08 2021 -0500 add ability to upgrade binary extensions commit db5bbf799fde38097889f016bb5447fad2ab2724 Author: vilmibm <[email protected]> Date: Wed Sep 22 16:11:12 2021 -0500 use manager io in Upgrade commit 7673622830445ca8497ba4036cc9263095b02ab1 Author: Mislav Marohnić <[email protected]> Date: Tue Sep 28 16:58:29 2021 +0200 Mount `gh codespace` command commit f749590e878cb985051d968b39aaf117ea469d18 Author: Mislav Marohnić <[email protected]> Date: Tue Sep 28 16:57:56 2021 +0200 Replace old "github/ghcs" import statements commit e64607d07b2c9c4937ab5de156846a814a654957 Merge: 425bc648 f947ef34 Author: Mislav Marohnić <[email protected]> Date: Tue Sep 28 16:46:27 2021 +0200 Merge remote-tracking branch 'ghcs/main' into import-codespaces Co-authored-by: Jose Garcia <[email protected]> commit f947ef3448e47cd0b1fa38e8f3e8a43d42bbfb52 Author: Mislav Marohnić <[email protected]> Date: Tue Sep 28 16:42:35 2021 +0200 Remove lightstep configuration The `github.com/shirou/gopsutil` dependency of lightstep-tracer is giving us trouble during building. Ref. https://github.com/shirou/gopsutil/issues/976 Another build problem raises its head even after we upgrade gopsutil to a version where the above bug is fixed. commit 0483765da5d44f761f345be46e43fb0625460cf5 Merge: 4015af04 c82d4c54 Author: Mislav Marohnić <[email protected]> Date: Tue Sep 28 15:46:57 2021 +0200 Merge pull request #190 from github/app-struct Introduce an App struct that executes core business logic commit 4015af0427421065486f31f982b69d5e55b69995 Merge: 8807b3a7 57d9b1a9 Author: Alan Donovan <[email protected]> Date: Mon Sep 27 18:04:55 2021 -0400 Merge pull request #192 from github/json-error create: decode JSON error heuristically commit 57d9b1a9e1acae43a14e4e577be5c1f41a8472a0 Author: Alan Donovan <[email protected]> Date: Mon Sep 27 14:51:52 2021 -0400 create: decode JSON error heuristically commit 425bc64859d5af805cad15f89892b9af0a1bf2ec Merge: 4d5ec86b 1f2ab7fb Author: Nate Smith <[email protected]> Date: Mon Sep 27 09:25:21 2021 -0700 Merge pull request #4090 from bchadwic/pr-checks Revised pending and skipped symbols for pr checks / run commands commit 4d5ec86b17924a619ed6f902736d6ccfa4daaf46 Merge: 750c3e38 f6e9734f Author: Mislav Marohnić <[email protected]> Date: Mon Sep 27 14:24:30 2021 +0200 Merge pull request #4291 from rethab/patch-1 docs: add hint how to use use stdin in api command commit f6e9734f171a49e24259459a84a1152014c998ac Author: Reto Hablützel <[email protected]> Date: Sat Sep 25 08:38:26 2021 +0200 add more hints to docs commit f5b0d01e86e8ca8d6700ee59d3f69eda6b9c3fdb Author: rethab <[email protected]> Date: Wed Sep 8 14:10:57 2021 +0200 docs: add hint how to use use stdin in api command commit 9e3893e10463757edf1dbf0c34fb8a4d3b6ed1e8 Author: Rasmus Wriedt Larsen <[email protected]> Date: Fri Sep 24 16:02:25 2021 +0200 Also set `pushRemote` on `gh pr checkout` from fork As explained in https://git-scm.com/docs/git-config#Documentation/git-config.txt-branchltnamegtremote if you have `remote.pushDefault` set in your global gitconfig (like I do), then _that_ setting will take precedence over `branch.<name>.remote` :disappointed: However, `branch.<name>.pushRemote` will take precedence over your `remote.pushDefault` setting, such that `gh pr checkout 123 && make changes && git push` will just work, even if you have `remote.pushDefault` set :muscle: commit c82d4c54724d9d879350052d7f0c993d92ec13c7 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 17:36:18 2021 +0200 Avoid passing params struct as pointer commit dc8f6ef183f6c4d7a0f4135376d54724302abb01 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 17:30:31 2021 +0200 No longer accept a logger in CreateCodespace The API layer shouldn't concern itself with logging progress to stderr. Instead, we will subsequently add progress indicators in the caller around CreateCodespace and other potentially slow commands as needed. commit ca0f89d3bc1bbf2292ec4e0e2b3fbf97e1047fd6 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 16:03:44 2021 +0200 Introduce an App struct that executes core business logic The Cobra commands are now a light wrapper around the App struct. Co-authored-by: Jose Garcia <[email protected]> commit 8807b3a73a701faf8b8905e7f76f1c086b6b5ba3 Merge: 92d0abd6 7a91ba59 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 16:02:36 2021 +0200 Merge pull request #184 from github/args-constraint Consistently institute constraints for position arguments and improve error message commit 92d0abd6ab079a584c2d00de99a19db6af617a19 Merge: 4eb15134 3d017b28 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 16:02:05 2021 +0200 Merge pull request #79 from github/raffo/delete-codespaces Add code and command to delete unused codespaces commit 3d017b282484617a73ca185d27dfcefedefe2e46 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 15:09:41 2021 +0200 Fix stderr output on delete errors commit 750c3e38f32d0bb845922fa4d96d0c9341928d1c Merge: 96aed388 b38ce244 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 14:50:59 2021 +0200 Merge pull request #4243 from wilso199/3704-credential-helper Fixes #4274 commit b38ce2449752a41c4a653671bb10f6938cabcca3 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 14:43:48 2021 +0200 Ensure correct path to `gh` after `gh auth refresh` git credential setup commit d853ce5bc980963d2136459d6707e889443997da Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 14:42:41 2021 +0200 Avoid resolving `executable()` until requested at runtime This is to avoid hitting the filesystem and resolving symlinks unnecessarily. The value of executable is just used conditionally by a handful of commands. commit 78b35b7b6eb4b24a3a776b145e8b443e4d80f4d2 Merge: d731cb9c 96aed388 Author: Mislav Marohnić <[email protected]> Date: Fri Sep 24 14:35:01 2021 +0200 Merge remote-tracking branch 'origin' into 3704-credential-helper commit 96aed3881945d9cbcbbe185603280ef96b601db4 Merge: 2c43436c 7bf85355 Author: Nate Smith <[email protected]> Date: Thu Sep 23 10:51:37 2021 -0700 Merge pull request #4308 from cli/ext-bin install binary extensions commit 4eb15134a465a356ed72ee18c20e56000751fc08 Merge: 3e26a153 5d6ea502 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 13:45:11 2021 -0400 Merge pull request #189 from github/jg/inline-go-liveshare Inline go-liveshare v0.20.0 commit 5d6ea5029ed7cf2ab39abf1cb2fc37da5883b842 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 13:36:04 2021 -0400 Linter fixes commit 65dcb0f428ff703135c43db9ce1246860905f469 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 13:22:20 2021 -0400 Linter fixes commit 08bc181d79f30f344f361494ac490762453edb16 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 13:16:20 2021 -0400 Linter fixes commit b8f35f950ca104c88489a9dd0f4586cd2a47fa36 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 13:14:35 2021 -0400 Linter fixes commit 75c1dfdf49e4b43c31704639d5d33b8361fb58e5 Author: Mislav Marohnić <[email protected]> Date: Thu Sep 23 18:57:22 2021 +0200 Fetch codespace by name directly if name argument given commit c4114cc972ccbccabbd3b7e1152703ebab12a892 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 11:58:55 2021 -0400 Linter fixes commit fb53ccb06a1b21e06ce2849d98c2c79f14e4ba76 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 11:56:41 2021 -0400 Linter fixes commit 958990cef83defd3c70278d3b4597c9165641128 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 11:47:52 2021 -0400 More linter fixes commit d0c65e549067426f80caf6dc5a99f99ffa4006cd Author: Jose Garcia <[email protected]> Date: Thu Sep 23 11:36:27 2021 -0400 Linter fixes commit f4396e8f1a0b79630e81b233b802d49cd0172dad Author: Jose Garcia <[email protected]> Date: Thu Sep 23 11:28:04 2021 -0400 Inline go-liveshare with history commit 9ae7eb586959369fa60819c83a2a22da67bd32af Merge: 3e26a153 6ca35d0e Author: Jose Garcia <[email protected]> Date: Thu Sep 23 11:19:46 2021 -0400 Merge branch 'go-liveshare-download' into jg/inline-go-liveshare commit 6ca35d0e730d1adaecc1c7c79c9c4892e2138449 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 11:18:49 2021 -0400 Moved files to liveshare dir commit e8212a80a9dcdbecb698f47bd45176ad1703bff1 Author: Mislav Marohnić <[email protected]> Date: Thu Sep 23 17:14:25 2021 +0200 Print `delete` failures as they occur commit 1232dba684f38721ffe34fe8d331f51362e44ce4 Merge: 32d3a384 3e26a153 Author: Mislav Marohnić <[email protected]> Date: Thu Sep 23 16:43:22 2021 +0200 Merge remote-tracking branch 'origin' into raffo/delete-codespaces commit 3e26a153429cfa34bb96f197fae89b3ae0e86d86 Merge: fb12f410 f1c35ba9 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 10:22:09 2021 -0400 Merge pull request #188 from github/jg/update-liveshare Update to go-liveshare v0.20.0 commit f1c35ba9daa06996205082f05a275ce97aa68297 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 10:21:01 2021 -0400 Update docs commit fb12f4108f362a1f1f1dc70872df621cd39ad14c Merge: a3c900c3 186b90b1 Author: Jose Garcia <[email protected]> Date: Thu Sep 23 10:10:57 2021 -0400 Merge pull request #181 from github/jg/poll-on-async-creation ghcs create: poll for codespaces that are being retried by the server commit a3c900c3b92b0c9d89a48179d2818332b8f403f0 Merge: 090e0c81 4e0ac15f Author: Jose Garcia <[email protected]> Date: Thu Sep 23 10:07:56 2021 -0400 Merge pull request #185 from github/jg/buffer-channels Add buffered to channels to avoid goroutine leak commit 9654dc4bd3711ed6ec00a112355313827cfe95bf Author: Jose Garcia <[email protected]> Date: Thu Sep 23 10:07:14 2021 -0400 Update to go-liveshare v0.20.0 commit 186b90b12e4d253d091a265714965bc96284c78f Author: Jose Garcia <[email protected]> Date: Thu Sep 23 08:29:24 2021 -0400 Rename request type commit 13d7804a359f8062817ec1e1da183da1e08a927a Author: Jose Garcia <[email protected]> Date: Thu Sep 23 08:26:23 2021 -0400 Remove API test, inline poller commit 7bf85355a92b80437df7470b53e12a554238d0fc Author: vilmibm <[email protected]> Date: Wed Sep 22 15:59:57 2021 -0500 restore cached client commit 5f02ed2656b5c2846505cb4c6a570f508a9bb7ad Author: vilmibm <[email protected]> Date: Wed Sep 22 15:59:50 2021 -0500 linter appeasement commit 4e0ac15fe045012a2398690fefefff66c86d43a7 Author: Jose Garcia <[email protected]> Date: Wed Sep 22 15:10:47 2021 -0400 Add buffer to channels to avoid goroutine leak commit 9a558bc58c0d6d2c9a50f6123242ba0e9bec1257 Author: Jose Garcia <[email protected]> Date: Wed Sep 22 15:03:12 2021 -0400 Early return if polling is not required - Add context to errors in poller commit 7a91ba5942f6535ce840312594ec5fcc630be5d8 Author: Mislav Marohnić <[email protected]> Date: Wed Sep 22 19:51:12 2021 +0200 Print usage help when args given to "NoArgs" commands commit a55f7af92c5e35491ed002e26b7105caf6d1fa5f Author: Mislav Marohnić <[email protected]> Date: Wed Sep 22 19:36:25 2021 +0200 Correct wrong args constraints commit 208f1721b5a29834c9f6420b765b95dd41ce7020 Author: Jose Garcia <[email protected]> Date: Wed Sep 22 13:21:02 2021 -0400 Rename ProvisionCodespaceParams commit 70a2ea2e6aaf36cd8e9206adab640892c7892d0d Author: Jose Garcia <[email protected]> Date: Wed Sep 22 13:19:26 2021 -0400 PR Feedback - Rename ProvisionCodespace -> CreateCodespace - Rename createCodespace -> startCreate - Additional docs/comments - Simplify ProvisionCodespaceParams commit d2d21996bc1a12a24f3b757e2fbc2ae933aa8a5e Author: Jose Garcia <[email protected]> Date: Wed Sep 22 11:49:41 2021 -0400 Move ProvisionCodespace to API client - Make CreateCodespace private along with its errors commit 32d3a38465ef15e8e7b305dccfef31dbc05c07f1 Author: Mislav Marohnić <[email protected]> Date: Wed Sep 22 16:39:50 2021 +0200 Name of the codespace commit cb7b535b917ffddc38f12069b32fbce5a4034eb7 Author: Mislav Marohnić <[email protected]> Date: Wed Sep 22 16:11:34 2021 +0200 Add tests for delete commit 8c5330d9e9691289c29bd6130efbca265985023c Author: Jose Garcia <[email protected]> Date: Wed Sep 22 10:04:18 2021 -0400 Rename error commit 2a0ea1617b3fccd06d29c4e4b81fd6d4b815fa15 Author: Jose Garcia <[email protected]> Date: Wed Sep 22 09:40:45 2021 -0400 Handle specific error for GetCodespaceToken commit 86717f14a1a6c0ba1f9f45f55367863541c69d53 Author: Jose Garcia <[email protected]> Date: Wed Sep 22 09:09:09 2021 -0400 Implement codespaces.Provision - Move polling logic into the Provision function - Document the behavior expected of callers when an ErrCreateAsyncRetry is returned commit 770151313fe4ac9d2b7a810d0d33b0e119069617 Merge: 77656280 f8a87135 Author: Alan Donovan <[email protected]> Date: Wed Sep 22 08:55:26 2021 -0400 Merge pull request #22 from github/connect Merge NewClient and JoinWorkspace into Connect commit 48e3473a953b9502a840bf9ea40fb818dca05f5b Author: Jose Garcia <[email protected]> Date: Tue Sep 21 18:18:30 2021 -0400 PR Feedback - Bring context.Timeout into the poller - Accept duration and interval - Other tidy up commit 514d4d992ce4900f18f286b241d788a01c721d0e Author: vilmibm <[email protected]> Date: Tue Sep 21 15:55:31 2021 -0500 refactor dependencies of ext manager commit f8a8713520f031758a2b75dc70c5faaea2927ea5 Author: Alan Donovan <[email protected]> Date: Tue Sep 21 15:23:02 2021 -0400 refactor Options API commit d2113e3b59e74c6a6b98f63779cde19750e09d9d Merge: c222c3d6 678da44c Author: Mislav Marohnić <[email protected]> Date: Tue Sep 21 21:10:29 2021 +0200 Merge branch 'mislav/delete-codespaces' into raffo/delete-codespaces commit 678da44c28506629da1feb53b34efbe59d38b7f0 Author: Mislav Marohnić <[email protected]> Date: Tue Sep 21 21:09:26 2021 +0200 Simplify delete further commit ab86739b6b168c35311b5dd1a4c4b0d18fbbb05a Merge: b894d3e1 090e0c81 Author: Mislav Marohnić <[email protected]> Date: Tue Sep 21 20:35:28 2021 +0200 Merge remote-tracking branch 'origin' into mislav/delete-codespaces commit 861811baf03d461e0d89113b07c80ff414c4e146 Author: Jose Garcia <[email protected]> Date: Tue Sep 21 14:02:05 2021 -0400 Upgrade pkg name after merge commit d5b03df4069a0691e05ebcdbafe8c5362c8b140f Merge: 323462ca 090e0c81 Author: Jose Garcia <[email protected]> Date: Tue Sep 21 14:01:37 2021 -0400 Merge branch 'main' of github.com:github/ghcs in…
Also fix test expectation for man contents: dash and underscore are no longer escaped with backslash in go-md2man v2.0.1 See cpuguy83/go-md2man#74
Also fix test expectation for man contents: dash and underscore are no longer escaped with backslash in go-md2man v2.0.1 See cpuguy83/go-md2man#74
Also fix test expectation for man contents: dash and underscore are no longer escaped with backslash in go-md2man v2.0.1 See cpuguy83/go-md2man#74
Currently, we escape a few characters, such as
-
(dash) becomes\-
(arithmetic minus sign)_
(underscore) becomes\_
(underline character)&
(ampersand) becomes\&
(zero-width space!)As a result, we have two bugs:
All
&
characters disappear from the resulting man page.Dashes are quite longer, and underscores becomes underlines (the
latter are lower). This is not reflected in text output, only in PDF
etc, and in most cases (like file names, command line options etc)
does not look good.
In fact, the only character that needs escaping is the backslash itself.
This is what this patch does, together with fixes to expected test
output.
The following commands were used to generate the example PDFs:
Before: go-md2man-old.pdf
After: go-md2man.pdf
Visual comparison:
Source for the above: