Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have draft addresses show too - consistent with cards mode #15911

Draft
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Oct 17, 2024

Description

Replication steps:

  • create Addresses field and set it to element index view mode
  • add that field to an entry type and the entry type to a section
  • create an entry in that section & save
  • edit the entry, click "New Address", fill out the required fields and click "Create address"
  • notice that the address doesn't show in the field until you reload the page

Additional info:
If you set the field to the cards view mode, the moment you start filling out the required fields, a card will start showing in the Addresses field.

Issue:
When in cards view mode, we explicitly grab all the nested elements, regardless of whether their type supports drafts or not.
When in element index view mode, the query never gets adjusted to pull in the drafts.

Solution:
For now, I have opted to bring this behaviour for Addresses field, in line with what the cards view does - show drafts straight away. That said, I'm not sure if really we want to go this way, or if it would be better to adjust how the cards view behaves and not show the drafts. But then this brings back the whole "how do I remove or continue editing an address if I accidentally closed the slideout" conversation. I've added this to the list to discuss in Monday meeting.

Related issues

n/a (found by Nathaniel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant