Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML in the message should be escaped #104

Closed
benface opened this issue Oct 31, 2017 · 7 comments
Closed

HTML in the message should be escaped #104

benface opened this issue Oct 31, 2017 · 7 comments
Assignees
@MakeilaLundy @Radabaugh
Labels
bug

Comments

@benface
Copy link

benface commented Oct 31, 2017

Any HTML entered by the user in the message field is rendered raw in the email's body. I believe that's a security issue, and if not, it's just annoying. :P
@brandonkelly
Copy link
Member

Agree that should not be the case.

@brandonkelly
Copy link
Member

@benface What version of Craft & Contact Form are you using?

@benface
Copy link
Author

benface commented Oct 31, 2017

@brandonkelly Version 1.9.1 running on Craft CMS 2.6.2993.

angrybrad added a commit that referenced this issue Oct 31, 2017
@angrybrad
Fixed #104
b6fee7e
@angrybrad
Copy link
Member

Fixed in https://github.com/craftcms/contact-form/releases/tag/1.9.2

angrybrad added a commit that referenced this issue Nov 1, 2017
@angrybrad
Really fix #104.
8672f12
@benface
Copy link
Author

benface commented Feb 18, 2018

@angrybrad Still seeing this in version 2.1.1 running on Craft CMS 3.0.0-RC10.1.

@benface
Copy link
Author

benface commented Mar 24, 2018

@angrybrad Did you see this? Should I submit a new issue?

@angrybrad angrybrad reopened this Mar 26, 2018
@angrybrad
Copy link
Member

@MakeilaLundy @Radabaugh this needs to be addressed for the v2 branch as well.

angrybrad added a commit that referenced this issue Mar 26, 2018
@angrybrad
Merge pull request #119 from craftcms/bugfix/contact-form-escape-HTML…
a560481 
…-104

fixed #104 for v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MakeilaLundy MakeilaLundy

@Radabaugh Radabaugh

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brandonkelly @angrybrad @benface @MakeilaLundy @Radabaugh