Add option for including all form data in email body #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2017
brandonkelly
requested changes
Oct 11, 2017
src/controllers/SendController.php
Outdated
| $submission->message = $request->getBodyParam('message'); | ||
|
|
||
| if ($settings->includeAllData) { | ||
| $submission->message = "<p>Name: {$request->getBodyParam('fromName')}</p>". |
There was a problem hiding this comment.
message should be set to Markdown-formatted text, not HTML. Each of these <p>s should be regular lines of text, separated by two \ns. Or perhaps a bullet list would work better here (begin each line with a - and separate them with single \ns).
src/models/Settings.php
Outdated
| @@ -32,6 +32,11 @@ class Settings extends Model | |||
| public $allowAttachments = false; | |||
|
|
|||
| /** | |||
| * @var bool | |||
| */ | |||
| public $includeAllData = false; | |||
There was a problem hiding this comment.
Not sure a setting is necessary for this. I'm sure most people would be fine to have the additional info in the body.
|
I remove the option and just loaded all the data into the email body by default. Also changed the formatting to Markdown and put actual line breaks |
brandonkelly
added a commit
that referenced
this pull request
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple toggle option that will include all the submitted data in the email message body. This is especially useful when sending the emails to a Gmail account which doesn't show the submitted email value (making the form almost useless at gathering contact info).
I attempted to add the German translation for the option with a mix of Google Translate and my rusty German skills, so a fix to make it more accurate/clear if it isn't already would be much appreciated.