Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Broken: Volume.php does not implement a validate method #4

Closed
Yugloocamai opened this issue Aug 30, 2018 · 3 comments
Closed
Assignees

Comments

@Yugloocamai
Copy link
Contributor

Yugloocamai commented Aug 30, 2018

I'm not sure how this plugin can work with Craft without a validate method. It does not work for me. When Craft3 calls saveVolume, it calls the validation method which will always return null since the method is not implemented. Perhaps Craft3 added that step recently?

        if ($runValidation && !$volume->validate()) {
            Craft::info('Volume not saved due to validation error.', __METHOD__);
            return false;
        }
@andris-sevcenko
Copy link
Contributor

The method is implemented in yii\base\Model, from which the craft\googlecloud\Volume inherits it.

@Yugloocamai
Copy link
Contributor Author

It looks like the validation error is actually Bucket cannot be blank., but the toast message on the front end is just Couldn’t save volume. I think the real issue here might just be messaging.

andris-sevcenko added a commit that referenced this issue Sep 3, 2018
@andris-sevcenko
Copy link
Contributor

Ah, nice find! Fixed for next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants