Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Logout #72

Merged
merged 1 commit into from
Apr 24, 2017
Merged

CLI: Logout #72

merged 1 commit into from
Apr 24, 2017

Conversation

jonsharratt
Copy link
Member

What did you implement:

Add logout cli support as per #71 @ganapativs

How did you implement it:

Takes the passed token then uses GitHub to reset it. One thing to note is that there is about a 4-5 sec cache before the custom authoriser then says it is invalid after testing.

How can we verify it:

  • Get branch and deploy it
  • Use npm logout
  • Attempt npm publish

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Tag ready for review or wip

Is this a breaking change?: NO

@jonsharratt jonsharratt merged commit 4697887 into master Apr 24, 2017
@jonsharratt jonsharratt deleted the add-logout branch April 24, 2017 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant