Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tarball Domain #79

Merged
merged 2 commits into from
May 3, 2017
Merged

Fix: Tarball Domain #79

merged 2 commits into from
May 3, 2017

Conversation

jonsharratt
Copy link
Member

@jonsharratt jonsharratt commented May 3, 2017

What did you implement:

Uses explicit url when setting tarball url on publish as can't rely on yarn and npm both working in the same way at the moment.

How did you implement it:

  • Use an env var against the publish function so it can be used.

How can we verify it:

  • Deploy registry, publish and install that package with a clean cache
  • npm t

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Tag ready for review or wip

Is this a breaking change?: NO

Yarn does some crazy things with the tarball url so setting explicitly.
@jonsharratt jonsharratt merged commit 8681bfa into master May 3, 2017
@jonsharratt jonsharratt deleted the fix-publish-domain branch May 3, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant