Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to correct hexadecimal values #19

Closed
epage opened this issue Jun 27, 2019 · 0 comments · Fixed by #32
Closed

Don't try to correct hexadecimal values #19

epage opened this issue Jun 27, 2019 · 0 comments · Fixed by #32
Labels
enhancement Improve the expected
Milestone
0.1

Comments

@epage
Copy link
Collaborator

epage commented Jun 27, 2019

Some hex numbers might appear as words and those words might look like typos. We should do like scspell and ignore them.
@epage epage added the enhancement Improve the expected label Jun 27, 2019
@epage epage changed the title Ignore hex Don't try to correct hexadecimal values Jul 13, 2019
@epage epage added this to the 0.1 milestone Jul 13, 2019
epage added a commit that referenced this issue Jul 14, 2019
@epage
feat(parser): Ignore hex literals
9d242fe 
Trying to avoid accidentally correcting something that looks like a word
inside a hex number, like `0xBEAF`.

Fixes #19
@epage epage mentioned this issue Jul 14, 2019
Merged
epage added a commit that referenced this issue Jul 14, 2019
@epage
feat(parser): Ignore hex literals
006204e 
Trying to avoid accidentally correcting something that looks like a word
inside a hex number, like `0xBEAF`.

Fixes #19
@epage epage closed this as completed in #32 Jul 14, 2019
epage added a commit that referenced this issue Apr 30, 2024
@epage
Merge pull request #19 from epage/t
dc3e937 
chore(ci): Ensure CI job always runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

feat(parser): Ignore hex literals crate-ci/typos
1 participant
@epage