Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use stack for table in Scalar::invert() to prevent leaking values to the heap (credits to @pornin) #33

Merged
merged 1 commit into from
Jul 13, 2023
Merged

use stack for table in Scalar::invert() to prevent leaking values to the heap (credits to @pornin) #33

merged 1 commit into from
Jul 13, 2023

Conversation

conradoplg
Copy link
Contributor

Closes #32 by allocating the table in stack.

kevaundray
kevaundray approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias!

@kevaundray kevaundray merged commit 04f42e4 into crate-crypto:master Jul 13, 2023
1 check passed
@mpguerra mpguerra mentioned this pull request Jul 24, 2023
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of zeroization in Scalar inversion
2 participants
@conradoplg @kevaundray