feat: Adapt to new types introduced in fiat-crypto 0.2 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, once fiat-crypto is released, please ping me! |
divergentdave
force-pushed
the
fiat-crypto-0.2
branch
from
31a5230
to
671c75e
Compare
divergentdave
force-pushed
the
fiat-crypto-0.2
branch
from
671c75e
to
3a0f361
Compare
|
It's out now, I've removed the pinned git commit |
kevaundray
approved these changes
Sep 2, 2023
kevaundray
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an outstanding PR that proposes some breaking changes to fiat-crypto, see mit-plv/fiat-crypto#1623. Briefly, it introduces new structures to replace type aliases, to prevent misuse of functions with different preconditions on their inputs' ranges. I'm opening this PR for a future upgrade early, with a
[patch.crates-io]stanza, to kick the tires on the breaking change, and for temporary use in fiat-crypto integration tests. If this looks good, I can back out the patch stanza whenfiat-cryptois released and mark it ready for review.