Implements __hash__ for collections
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Julian Hi Julian, just a friendly ping, this PR is ready for review whenever you're ready :)) |
|
Hey! Apologies, I missed it! Thanks for the ping, will have a look. |
|
I've been a bit tied up but just mentioning I still will try to look at this in the next few days, sorry for the delay! |
|
No worries at all! Take your time :)) |
|
Thanks again, good work! I've merged and tagged a release, so this should go out imminently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
__hash__toHashTrieSet,HashTrieMap, andListso that the instances of them are hashable (if underlaying elements are hashable).Related to #50