Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashing overflow issues (#86) #87

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

FlickerSoul
Copy link
Contributor

This PR fixes overflow errors during hashing persistent data structures.

@Julian
Copy link
Member

Julian commented Aug 15, 2024

Nice! Any chance you also might take a stab at the suggestion to run with --profile=dev in CI? I'm not 100% sure what it does (so a good first step is probably double checking) but if we don't add it, it's obviously likely we could accidentally add some other thing which trips it.

@FlickerSoul
Copy link
Contributor Author

FlickerSoul commented Aug 15, 2024

It looks like the arguments are passed to maturin and then to cargo during building rpds. See here and here. The dev profile enables the overflow check and that's why we see the errors in the issue. It could be helpful in terms of debugging and producing extra information, I think?

@Julian
Copy link
Member

Julian commented Aug 15, 2024

From that page it would seem like we should run with --profile=test, which implies dev.

@FlickerSoul
Copy link
Contributor Author

Yes I think test would make more sense. I can modify the CI to do that :)

@Julian
Copy link
Member

Julian commented Sep 2, 2024

@FlickerSoul let me know if you're still up for making the CI change! (Thanks again for your work so far)

@Julian Julian merged commit 06d98b9 into crate-py:main Oct 31, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants