TopologySpreadConstraints: add minDomains=3 #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goat-ssh
requested review from
plaharanne,
tomach,
WalBeh,
Taliik,
juanpardo and
widmogrod
as code owners
5 tasks
WalBeh
reviewed
Sep 20, 2024
CHANGES.rst
Outdated
| @@ -17,6 +17,7 @@ Unreleased | |||
|
|
|||
| * Added configuration for JWT authentication from CrateDB version 5.7.2 onwards. | |||
| * Bumped version of the JMX Exporter to ``1.2.0`` | |||
| * Add ``minDomains`` to ``TopologySpreadConstraint`` to ensure that pods are spread across zones. | |||
There was a problem hiding this comment.
I think this goes into Unreleased.
This help Cluster Autoscaler to provision nodes in zone which are set to 0 nodes. Require at least 3 nodes (as we have 3 zones) https://kubernetes.io/blog/2023/04/17/fine-grained-pod-topology-spread-features-beta/#kep-3022-min-domains-in-pod-topology-spread
goat-ssh
force-pushed
the
s/mindomains
branch
from
a053e05
to
186cc18
Compare
WalBeh
approved these changes
Sep 20, 2024
| @@ -270,6 +270,7 @@ def get_topology_spread( | |||
| topology_spread = [ | |||
| V1TopologySpreadConstraint( | |||
| max_skew=1, | |||
| min_domains=3, | |||
There was a problem hiding this comment.
Not 100% sure whether we can always add this, or need to be more granular depending on the setup, or scaling of a cluster.
There was a problem hiding this comment.
Looks like we add the topologySpreadContraints on all the Statefulset and the Setting seemingly does not hurt eg. on a Nodegroup with only one Availability Zone.
(To answer my question, myself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This help Cluster Autoscaler to provision nodes in zone which are set to 0 nodes.
Require at least 3 nodes (as we have 3 zones)
https://kubernetes.io/blog/2023/04/17/fine-grained-pod-topology-spread-features-beta/#kep-3022-min-domains-in-pod-topology-spread
Summary of changes
Checklist
CHANGES.rst