-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility for PHP8 #116
Merged
Commits on Feb 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 81bf5a0 - Browse repository at this point
Copy the full SHA 81bf5a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a605e8 - Browse repository at this point
Copy the full SHA 1a605e8View commit details
Commits on Feb 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 28e6972 - Browse repository at this point
Copy the full SHA 28e6972View commit details -
We found that Coveralls is not able to merge coverage reports from different job runs. Since supporting PHP8, we have different code branches in order to support the old and the new PDO interface. So, it is crucial to merge coverage reports from two job runs, one for PHP7.4 and another for PHP8.
Configuration menu - View commit details
-
Copy full SHA for b1e30c3 - Browse repository at this point
Copy the full SHA b1e30c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f19af7b - Browse repository at this point
Copy the full SHA f19af7bView commit details -
Improve test suite by adding "composer run multicover"
This will aid on running the tests with coverage on both PHP7 and PHP8, merge coverage reports and render them as HTML to be inspected by humans. It's not completely maintenance free because some paths will probably have to be adjusted for others, but it's way better than nothing.
Configuration menu - View commit details
-
Copy full SHA for 6cb24c3 - Browse repository at this point
Copy the full SHA 6cb24c3View commit details -
Improve code coverage to satisfy Codecov
With the introduction of PHP8 compatibility, some `class_alias` code has been introduced. We have not been able to make PHPUnit grok the coverage of this code by other means. Additionally, some annotations have been added to improve code coverage metrics on code which actually has been covered but was not accounted.
Configuration menu - View commit details
-
Copy full SHA for 893bc20 - Browse repository at this point
Copy the full SHA 893bc20View commit details
Commits on Feb 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3263258 - Browse repository at this point
Copy the full SHA 3263258View commit details -
Configuration menu - View commit details
-
Copy full SHA for e314fb8 - Browse repository at this point
Copy the full SHA e314fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c1693d - Browse repository at this point
Copy the full SHA 1c1693dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.