[WIP] Add baseline infrastructure for emulating materialized views #56
Conversation
| # FIXME: SQLParseException[Target table name must not include a schema] | ||
| sql_ddl = f"ALTER TABLE {mview.staging_table_fullname} RENAME TO {mview.table_name}" | ||
| logger.info(f"Activating materialized view: {sql_ddl}") | ||
| self.store.execute(sa.text(sql_ddl)) |
There was a problem hiding this comment.
This needs a ticket in crate/crate, about that currently, you can't rename a table "into a different schema", i.e. it will always be doc.
There was a problem hiding this comment.
It looks like resolving this issue might not be too difficult. If someone has the capacity to file a corresponding issue at crate/crate, I will appreciate it. /cc @hammerhead, @hlcianfagna 🌻
// we do not support renaming to a different schema, thus the target table identifier must not include a schema
// this is an artificial limitation, technically it can be done
List<String> newIdentParts = node.newName().getParts();
if (newIdentParts.size() > 1) {
throw new IllegalArgumentException("Target table name must not include a schema");
}There was a problem hiding this comment.
@hlcianfagna suggested to use ALTER CLUSTER SWAP TABLE as a workaround at crate/crate#14833 (comment). Thank you.
| # TODO: IF NOT EXISTS | ||
| sql_ddl = f"CREATE TABLE {mview.staging_table_fullname} AS (\n{mview.sql}\n)" | ||
| logger.info(f"Creating materialized view (staging): {sql_ddl}") | ||
| self.store.execute(sa.text(sql_ddl)) |
There was a problem hiding this comment.
This is another spot where I discovered a shortcoming in SQL syntax: CREATE TABLE ... AS ... does not support the IF NOT EXISTS infix.
There was a problem hiding this comment.
We filed a database issue about it.
What the title says. Description will be expanded while we go.