-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GitHub action that use Testing Farm #4320
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
44eb1cf
to
bd41140
Compare
I need to log in to the self-host runner to do some debug. So need to add my ssh public key into the github self-host runner from the testing farm. Waitting for https://gitlab.com/testing-farm/infrastructure/-/merge_requests/698 to be merged now. |
@adrianriobo Hi, I'm debugging run crc tests with machine from TestingFarm. The issue is, we can only use the self-host runner(also from TestingFarm) to provision and connect to the arm64 machine from TestingFarm. That means we can't connect to the machine with a container(deliverset image). So I think we can't use the container method to run crc tests with Testing Farm. |
.github/workflows/linux-qe.yml
Outdated
echo $SSH_AGENT_PID > ssh_agent_pid | ||
#kill $(cat ssh_agent_pid) | ||
ssh-add id_rsa | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need api invoke to add this as check for the PR
crc/.github/workflows/windows-qe-tpl.yml
Line 84 in 0342835
- name: Add status to the PR check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM although I would prefer to tackle the comments. Although I am also fine if you want to have it in ASAP and the create a follow up one to fix the comments.
@@ -40,6 +40,14 @@ jobs: | |||
with: | |||
name: windows-installer | |||
path: "./out/windows-amd64/crc-windows-installer.zip" | |||
- name: Build Linux binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a follow up issue on this one, about to renaming this action (as now it also includes linux build, it would be great to properly name it).
Also ensure linux build is only done in one place
-v "$(cat ssh_auth_sock):$(cat ssh_auth_sock)" \ | ||
-v ${PWD}:/data:z \ | ||
-v ${PWD}/crc:/opt/crc-support/crc:z \ | ||
quay.io/rhqp/crc-support:v0.5.1-linux crc-support/install.sh crc-support/crc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quay.io/crc-org/ci-crc-support:v1.0.0-linux
Is now available. If possible change to this as from now on it should be the "official" one.
Let me do a check on using it directly with crc
as a local asset. And will add here the snippet to make use of it here.
91da447
to
af93479
Compare
@lilyLuLiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
#4326