Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: inline forms #147

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wlatanowicz
Copy link

@wlatanowicz wlatanowicz commented Nov 18, 2022

This PR adds an option to add a simple inline form next to the action button:

Screenshot 2022-11-18 at 11 34 42

@wlatanowicz wlatanowicz force-pushed the feature/forms branch 2 times, most recently from b2d02eb to 7821c64 Compare November 18, 2022 10:33
@crccheck
Copy link
Owner

interesting. It would be nice to switch from a GET to a POST see #16
I'd want to split this PR into that first before adding a new feature.

For this specific use case of sending additional values to the action, I always thought about using an interstitial page instead of expanding what the button can do. I'm not so sure about adding this kind of functionality since Django Admin Actions don't have an equivalent

@wlatanowicz
Copy link
Author

Thanks for the comment. I'll create a separate PR for POST. It's already in a separate commit.

For inline forms: Adding inline forms does not prevent you from using interstitial pages. IMO It's just handy to have the option to add a simple input instead of building a separate two-stage form. You gave me something to think about, though. I'm going to rename the property to inline_form for sure. Another thing is that maybe I can easily use a similar concept to build interstitial pages, so you don't have to struggle with templates on your own. Give me a couple of days to play around with it.

Wiktor Latanowicz and others added 2 commits December 28, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants