wip to select GET or POST for actions

django_object_actions/templates/django_object_actions/action_trigger.html

@@ -0,0 +1,22 @@
+{% load add_preserved_filters from admin_urls %}
+
+{% if tool.button_type == 'a' %}
+  <a href="{% add_preserved_filters action_url %}"
+    title="{{ tool.standard_attrs.title }}"
+    {% for k, v in tool.custom_attrs.items %}
+      {{ k }}="{{ v }}"
+    {% endfor %}
+    class="{{ tool.standard_attrs.class }}"
+  >{{ tool.label|capfirst }}</a>
+{% elif tool.button_type == 'form' %}
+  <form method="post" action="{% add_preserved_filters action_url %}">
+    {% csrf_token %}
+    <a href="#" onclick="this.parentNode.submit(); return false;"
+      title="{{ tool.standard_attrs.title }}"
+      {% for k, v in tool.custom_attrs.items %}
+        {{ k }}="{{ v }}"
+      {% endfor %}
+      class="{{ tool.standard_attrs.class }}"
+    >{{ tool.label|capfirst }}</a>
+  </form>
+{% endif %}

django_object_actions/templates/django_object_actions/change_form.html

@@ -1,17 +1,10 @@
 {% extends "admin/change_form.html" %}
-{% load add_preserved_filters from admin_urls %}
 
 {% block object-tools-items %}
   {% for tool in objectactions %}
     <li class="objectaction-item" data-tool-name="{{ tool.name }}">
       {% url tools_view_name pk=object_id tool=tool.name as action_url %}
-      <a href="{% add_preserved_filters action_url %}" title="{{ tool.standard_attrs.title }}"
-         {% for k, v in tool.custom_attrs.items %}
-           {{ k }}="{{ v }}"
-         {% endfor %}
-         class="{{ tool.standard_attrs.class }}">
-      {{ tool.label|capfirst }}
-      </a>
+      {% include 'django_object_actions/action_trigger.html' %}
     </li>
   {% endfor %}
   {{ block.super }}

django_object_actions/templates/django_object_actions/change_list.html

@@ -1,17 +1,10 @@
 {% extends "admin/change_list.html" %}
-{% load add_preserved_filters from admin_urls %}
 
 {% block object-tools-items %}
   {% for tool in objectactions %}
     <li class="objectaction-item" data-tool-name="{{ tool.name }}">
       {% url tools_view_name tool=tool.name as action_url %}
-      <a href="{% add_preserved_filters action_url %}" title="{{ tool.standard_attrs.title }}"
-         {% for k, v in tool.custom_attrs.items %}
-           {{ k }}="{{ v }}"
-         {% endfor %}
-         class="{{ tool.standard_attrs.class }}">
-      {{ tool.label|capfirst }}
-      </a>
+      {% include 'django_object_actions/action_trigger.html' %}
     </li>
   {% endfor %}
   {{ block.super }}

django_object_actions/utils.py

@@ -5,7 +5,7 @@
 from django.contrib.admin.utils import unquote
 from django.db.models.query import QuerySet
 from django.http import Http404, HttpResponseRedirect
-from django.http.response import HttpResponseBase
+from django.http.response import HttpResponseBase, HttpResponseNotAllowed
 from django.views.generic import View
 from django.views.generic.detail import SingleObjectMixin
 from django.views.generic.list import MultipleObjectMixin
@@ -159,6 +159,7 @@ def _get_tool_dict(self, tool_name):
             label=getattr(tool, "label", tool_name.replace("_", " ").capitalize()),
             standard_attrs=standard_attrs,
             custom_attrs=custom_attrs,
+            button_type=tool.button_type,
         )
 
     def _get_button_attrs(self, tool):
@@ -238,7 +239,7 @@ def back_url(self):
         """
         raise NotImplementedError
 
-    def get(self, request, tool, **kwargs):
+    def dispatch(self, request, tool, **kwargs):
         # Fix for case if there are special symbols in object pk
         for k, v in self.kwargs.items():
             self.kwargs[k] = unquote(v)
@@ -248,15 +249,15 @@ def get(self, request, tool, **kwargs):
         except KeyError:
             raise Http404("Action does not exist")
 
+        if request.method not in view.methods:
+            return HttpResponseNotAllowed(view.methods)
+
         ret = view(request, *self.view_args)
         if isinstance(ret, HttpResponseBase):
             return ret
 
         return HttpResponseRedirect(self.back_url)
 
-    # HACK to allow POST requests too
-    post = get
-
     def message_user(self, request, message):
         """
         Mimic Django admin actions's `message_user`.
@@ -314,7 +315,9 @@ def decorated_function(self, request, queryset):
 
 
 def action(
-    function=None, *, permissions=None, description=None, label=None, attrs=None
+    function=None, *, permissions=None, description=None, label=None, attrs=None,
+    methods=('GET', 'POST'),
+    button_type='a',
 ):
     """
     Conveniently add attributes to an action function:
@@ -349,6 +352,8 @@ def decorator(func):
             func.label = label
         if attrs is not None:
             func.attrs = attrs
+        func.methods = methods
+        func.button_type = button_type
         return func
 
     if function is None: