Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: applied black formatting #170

Merged
merged 1 commit into from
Apr 11, 2024
Merged

style: applied black formatting #170

merged 1 commit into from
Apr 11, 2024

Conversation

mschfh
Copy link
Contributor

@mschfh mschfh commented Apr 9, 2024

No description provided.

@crccheck
Copy link
Owner

Random thoughts

  1. I wonder if I should pin what version of Black is used
  2. I wonder if I should switch to ruff. I've been using it elsewhere and it's nice to have have a lot of linting tools in one place

@mschfh
Copy link
Contributor Author

mschfh commented Apr 10, 2024

Or consider pre-commit hooks:
https://black.readthedocs.io/en/stable/integrations/source_version_control.html#version-control-integration

And a Github Action to run them in CI (for consistency):
https://github.com/pre-commit/action

@crccheck
Copy link
Owner

I avoided pre-commit because it didn't feel like a lot of people used it in Python but it feels like it's ready now. It's weird how you have to double specify your dependencies since it's a language agnostic project but ¯\_(ツ)_/¯

@crccheck
Copy link
Owner

I was going to save this and roll it into a lint PR but who am I kidding... I'm not going to get to it for awhile

@crccheck crccheck merged commit fb3ce5b into crccheck:master Apr 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants