Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for caching subsequent requests to the same resource #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sharq88
Copy link

@sharq88 sharq88 commented Nov 10, 2017

Separated into 3 commit (white spaces makes it difficult to see what's going on)
If you have a look at this link, it makes a bit more sense what's going on...
c5faace

The problem is if you have 10 reference to the same SVG on the page, that means 10 request to the same object, which is not desired, as it causes like a waterfall effect, images showing up one by one with a little delay.

data-src was added, so it does not kick off the downloading automatically.

Feel free to merge or update. We use a different version originated from this repo, so I thought to submit a version for you, as it might affect others.

Regards
SQ

@sharq88 sharq88 changed the title Dev/peter add support for caching subsequent requests to the same resource Nov 10, 2017
@unclechu
Copy link
Collaborator

@sharq88 please, keep formatting as it was, it's really hard to get what changed in the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants