-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DarkTurquoise to ForestGreen #72
Conversation
I guess there are again issues.I reforked the repository after deleting the old one and still facing this issue |
@Aakash2408 you're fine, I updated the branch again. You need to select the correct branch when making the PR in GitHub. |
It doesn't look like the changes showed up, though. |
I will just check in local |
a9c8bfc
to
60acbcc
Compare
Why the test is failing @kgodey :( |
I'm not 100%, but I think the test is failing due to secrets not being available to forks (a known issue with PRs from forks: actions/checkout#298 (comment)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! Just a few changes:
- On home page and Scholarship list page, the scholarship cards should change the background color too (
has-background-forest-green
).
I didn't know about the secrets not available for forks ❗ we'll look at that apart but your code is running okay.
legal_db/static/styles.scss
Outdated
@@ -207,7 +207,7 @@ a, a:hover { | |||
} | |||
|
|||
footer a:hover { | |||
color: $color-dark-turquoise; | |||
color: $color-forest-green; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must keep the turquoise color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i will look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must keep the turquoise color.
do I only need to change it back to dark-turquoise on the hover on the footer
Yes I guess the secret_key is not set. |
@krysal @TimidRobot Can you kindly review the changes in code, am not sure about this test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Fixes
Fixes #62 by @panchovm
Description
Replaced DarkTurquoise with ForestGreen across all site
Technical details
ForestGreen:RGB(4,166,53)
Screenshots
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin