Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All files moved to Hooks #33

Merged
merged 2 commits into from
Jan 26, 2021
Merged

All files moved to Hooks #33

merged 2 commits into from
Jan 26, 2021

Conversation

set
Copy link
Contributor

@set set commented Apr 5, 2020

Hi! I have moved to all components to Functional Component with Hooks!

@einazare
Copy link
Contributor

einazare commented Apr 6, 2020

Hello there, @set ,

That is great.
We'll check it a bit later this week and see if we can merge it.
The problem is that there are 258 files changed, and we need to make a thorough check to this PR.
Also, for it to be accepted, you need to point it to the dev-master branch.

Best,
Manu

@set
Copy link
Contributor Author

set commented Apr 6, 2020

Hi @einazare yes that is a problem. I think this is a file system error because there are a lot of files have no different.

@set set changed the base branch from master to dev-master April 7, 2020 17:10
@set set changed the base branch from dev-master to master April 7, 2020 17:10
@set set changed the base branch from master to dev-master April 15, 2020 10:13
Base automatically changed from dev-master to dev-main January 26, 2021 12:25
@einazare einazare merged commit cc292af into creativetimofficial:dev-main Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@set @einazare