Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog backdrop should be at least screen height #649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marlier
Copy link

@marlier marlier commented Mar 12, 2024

If/when #648 is merged, it will allow a Dialog that is taller than the screen to be rendered correctly. However, the backdrop is currently fixed at the height of the screen. This changes the default theme so that the backdrop is at least the screen height, but will become taller should the content be larger than the viewport.

Workaround for the time being is to set your custom theme as

<ThemeProvider
                  value={{
                    dialog: {
                      styles: {
                        base: {
                          backdrop: {
                            position: 'relative',
                            height: 'min-h-screen',
                          },
                        },
                      },
                    },
                  }}
                >

Copy link

vercel bot commented Mar 12, 2024

@marlier is attempting to deploy a commit to the ct-tailwind-team Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant