Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve error handling for verification service #365

Closed
2 tasks done
bhavanakarwade opened this issue Dec 21, 2023 · 1 comment · Fixed by #384 or #385
Closed
2 tasks done

refactor: improve error handling for verification service #365

bhavanakarwade opened this issue Dec 21, 2023 · 1 comment · Fixed by #384 or #385
Assignees
Labels
enhancement New feature or request

Comments

@bhavanakarwade
Copy link
Contributor

bhavanakarwade commented Dec 21, 2023

  • API routes should be self-explanatory & aligned with functionality.
  • Change Promise<object> to an interface.
  • Refactor responses (Only necessary fields should populate in response).
  • Check status codes
  • Check role-wise authentication to APIs with RoleGuards
  • Check API status and statusCode should be checked properly.
  • Error logs should be there wherever necessary.
  • End-to-end testing.
  • ESLint rules should not be disabled unless necessary
  • Validation on Payload.
  1. Apply trim() on payload.
  2. Apply toString(), toNumber() datatypes properly to payloads.
  3. Apply toOptional() if parameters are optionals.
  4. Apply notNull for parameters of payloads if not optional.
  • Error Response.

ex:

{
  "message": "User friendly message",
  "error": "Some error description/error stack",
  "statusCode": 400,
}

  • API's :

  • Get all proof presentations by OrgId

  • Webhook call for store proof presentations

@bhavanakarwade bhavanakarwade self-assigned this Dec 21, 2023
@bhavanakarwade bhavanakarwade added the enhancement New feature or request label Dec 21, 2023
@bhavanakarwade bhavanakarwade linked a pull request Jan 8, 2024 that will close this issue
@bhavanakarwade bhavanakarwade changed the title Improve error handling for verification service refactor: improve error handling for verification service Apr 10, 2024
@bhavanakarwade
Copy link
Contributor Author

completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant