Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get all proof presentations API #384

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

bhavanakarwade
Copy link
Contributor

What

  • Refactored the GET API orgs/{orgId}/proofs
  1. Implemented a well-defined interface by replacing previous existing Promise<object>.
  2. Checked validations on payload.
  3. Refactor response
  4. Ensured consistency of API status codes.
  5. Modified the NATS function.

Why

  • The implementation of a well-defined interface enhances code readability and makes the structure of the API response more explicit.
  • Ensuring consistent API status codes improves communication between different components of the system and enhances overall reliability.

How

  • Replaced the return type with a well-defined interface to enhance code clarity.
  • Checked and standardized API status codes to ensure a uniform response.
  • Modified the NATS function to accommodate the adjustments made in the API.

@bhavanakarwade bhavanakarwade self-assigned this Dec 28, 2023
@bhavanakarwade bhavanakarwade linked an issue Dec 28, 2023 that may be closed by this pull request
2 tasks
Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vivekayanworks vivekayanworks merged commit ae0ce46 into nats-refactor Dec 28, 2023
2 checks passed
@vivekayanworks vivekayanworks deleted the refactor-get-all-proof-presentations branch December 28, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: improve error handling for verification service
2 participants