Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added validation for schema and cred-def and updated payload for create request cred-def #149

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

KulkarniShashank
Copy link
Contributor

What

Added validation for the schema and credential definition (cred-def).
Changed the payload to include the value and type for the create request credential definition (cred-def).

Why

The changes were made to enhance the security and accuracy of the credential creation process. By implementing schema and cred-def validation, we can ensure that the data being used is correct and secure.

How

Implemented schema and cred-def validation in the code.
Updated the payload structure to include "value" and "type" for create request credential definitions.

Signed-off-by: KulkarniShashank <[email protected]>
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tipusinghaw tipusinghaw merged commit d4d124d into develop Oct 13, 2023
3 checks passed
@tipusinghaw tipusinghaw deleted the schema-cred-def-validation branch October 13, 2023 07:01
KulkarniShashank added a commit that referenced this pull request Oct 25, 2023
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 11, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 12, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 12, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 12, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank added a commit that referenced this pull request Sep 12, 2024
… create request cred-def (#149)

* fix: Added validation for the schema and cred-def request creation

Signed-off-by: KulkarniShashank <[email protected]>

* Remove commented code

Signed-off-by: KulkarniShashank <[email protected]>

---------

Signed-off-by: KulkarniShashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants