Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor api for passkey module (backend) #154

Merged
merged 10 commits into from
Oct 18, 2023
Merged

feat: refactor api for passkey module (backend) #154

merged 10 commits into from
Oct 18, 2023

Conversation

bhavanakarwade
Copy link
Contributor

What

  • Refactor API for Passkey Module.
  • Handled condition for passkey for sign up process.

Why

  • To improve the code structure, functionality, or performance of the Passkey Module's API.
  • For better user experience.

@bhavanakarwade bhavanakarwade added the enhancement New feature or request label Oct 13, 2023
@bhavanakarwade bhavanakarwade self-assigned this Oct 13, 2023
@bhavanakarwade bhavanakarwade linked an issue Oct 13, 2023 that may be closed by this pull request
bug: standardized API for passkey module (BE) #152
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

KulkarniShashank
KulkarniShashank approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KulkarniShashank KulkarniShashank merged commit 5213031 into develop Oct 18, 2023
3 checks passed
@nishad-ayanworks nishad-ayanworks deleted the refactor-api-for-passkey-module branch December 6, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

@nishad-ayanworks nishad-ayanworks Awaiting requested review from nishad-ayanworks

@tipusinghaw tipusinghaw Awaiting requested review from tipusinghaw

Assignees

@bhavanakarwade bhavanakarwade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: standardized API for passkey module (BE)
2 participants
@bhavanakarwade @KulkarniShashank