Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devops #3

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Devops #3

merged 2 commits into from
Aug 4, 2023

Conversation

Sheetal-ayanworks
Copy link
Contributor

What?

  • Converted a Dockerfile into a multistage Dockerfile.
  • Optimized Docker image size by using the Alpine version.
  • Changed the location of the Dockerfile to the parent directory.

Why?

  • Resolved context path issues.
  • Minimized Docker image size by utilizing Alpine version.

How?

  • Utilized a code build as stage 1 in the multistage Dockerfile.
  • Copied the dist/build folder and node_modules into the final image.

@Sheetal-ayanworks Sheetal-ayanworks self-assigned this Aug 4, 2023
KulkarniShashank
KulkarniShashank approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KulkarniShashank KulkarniShashank merged commit 8b18346 into main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

Assignees

@Sheetal-ayanworks Sheetal-ayanworks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sheetal-ayanworks @KulkarniShashank