Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pagination, sorting feature functionality and schema validations bug #346

Merged
merged 5 commits into from
Dec 15, 2023
Merged

fix: pagination, sorting feature functionality and schema validations bug #346

merged 5 commits into from
Dec 15, 2023

Conversation

bhavanakarwade
Copy link
Contributor

@bhavanakarwade bhavanakarwade commented Dec 14, 2023 •
edited
Loading

What

  • Resolved schema validation bugs during Schema Creation, including:
  1. Duplicate attribute names validation.
  2. Case-insensitive duplicate attribute names validation.
  3. Trim validations during attribute storage on the ledger and in the database.
  • Refactor pagination and sorting features functionality.

Why

  • To ensure uniqueness, introduced case-insensitive validations for attribute names to prevent ambiguity, and incorporated trimming validations during attribute storage for consistent handling of leading and trailing spaces, enhancing data integrity.

@bhavanakarwade
fix: schema validations bugs
fbda26d 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade bhavanakarwade added the bug Something isn't working label Dec 14, 2023
@bhavanakarwade bhavanakarwade self-assigned this Dec 14, 2023
@bhavanakarwade bhavanakarwade linked an issue Dec 14, 2023 that may be closed by this pull request
Schema validation bugs during Schema Creation (backend) #347
Closed
3 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bhavanakarwade bhavanakarwade changed the title fix: schema validations bug fix: pagination, sorting feature functionality and schema validations bug Dec 15, 2023
nishad-ayanworks
nishad-ayanworks approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit 9d25794 into develop Dec 15, 2023
2 checks passed
@bhavanakarwade bhavanakarwade deleted the schema-validations branch March 7, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

@KulkarniShashank KulkarniShashank Awaiting requested review from KulkarniShashank

Assignees

@bhavanakarwade bhavanakarwade

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema validation bugs during Schema Creation (backend)
2 participants
@bhavanakarwade @nishad-ayanworks