Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: API create tenant #374

Merged
merged 5 commits into from
Dec 27, 2023
Merged

refactor: API create tenant #374

merged 5 commits into from
Dec 27, 2023

Conversation

KulkarniShashank
Copy link
Contributor

What

Restructured the code to create a Tenant Creation API.

Why

  • Enhance code readability and maintainability.
  • Improve performance and optimize resource utilization.
  • Align with best practices for API design.

How

  • Reorganized and optimized the existing codebase for the Tenant Creation API.
  • Addressed code smells and improved overall code quality.
  • Verified changes through thorough testing to ensure functionality remains intact.
  • Documented the refactoring process for better transparency and understanding.

@KulkarniShashank
refactor: API create tenant
0c8f00a 
Signed-off-by: KulkarniShashank <[email protected]>
@KulkarniShashank KulkarniShashank self-assigned this Dec 26, 2023
@KulkarniShashank KulkarniShashank linked an issue Dec 26, 2023 that may be closed by this pull request
Improve error handling for agent & provisioning service #357
Closed
3 tasks
@KulkarniShashank
Solved the conflicts as per comment
c660e29 
Signed-off-by: KulkarniShashank <[email protected]>
vivekayanworks
vivekayanworks reviewed Dec 27, 2023
View reviewed changes
libs/common/src/response-messages/index.ts Outdated Show resolved Hide resolved
libs/common/src/response-messages/index.ts Outdated Show resolved Hide resolved
apps/agent-service/src/agent-service.service.ts Outdated Show resolved Hide resolved
@KulkarniShashank
Solved the conflicts as per comment
b46edab 
Signed-off-by: KulkarniShashank <[email protected]>
@vivekayanworks vivekayanworks merged commit 887369b into nats-refactor Dec 27, 2023
1 check passed
@vivekayanworks vivekayanworks deleted the API-create-tenant branch December 27, 2023 12:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekayanworks vivekayanworks vivekayanworks approved these changes

@ankita-p17 ankita-p17 Awaiting requested review from ankita-p17

@nishad-ayanworks nishad-ayanworks Awaiting requested review from nishad-ayanworks

Assignees

@KulkarniShashank KulkarniShashank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error handling for agent & provisioning service
2 participants
@KulkarniShashank @vivekayanworks