Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create service name random in shell script #393

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

KulkarniShashank
Copy link
Contributor

What

Create a random service name within the shell script. It eliminates unnecessary parameters related to agent provisioning.

Why

The current script includes unceremonious parameters and agent-provisioning, which are redundant and can lead to issues. This fix aims to streamline the script by removing these unnecessary elements.

How

Script to generate a random service name without the need for explicit parameters and eliminating the agent-provisioning code. The updated script is designed to improve simplicity and efficiency.

Copy link
Contributor

@Sheetal-ayanworks Sheetal-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

2 Security Hotspots
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@KulkarniShashank KulkarniShashank merged commit 376c5a4 into nats-refactor Dec 29, 2023
1 of 2 checks passed
@KulkarniShashank KulkarniShashank deleted the Agent-Authentication branch March 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants