Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validation on pagination #433

Merged
merged 10 commits into from
Jan 14, 2024
Merged

fix: validation on pagination #433

merged 10 commits into from
Jan 14, 2024

Conversation

pranalidhanavade
Copy link
Contributor

What

  • Applied validations for page number and page size.

@pranalidhanavade pranalidhanavade self-assigned this Jan 11, 2024
@pranalidhanavade
fix:sonacloud issues
0d791d5 
Signed-off-by: pranalidhanavade <[email protected]>
@pranalidhanavade
refactor:get invitations
8880777 
Signed-off-by: pranalidhanavade <[email protected]>
@pranalidhanavade
refactor:excluded delete org api
64ab508 
Signed-off-by: pranalidhanavade <[email protected]>
@pranalidhanavade
refactor:delete org invitations api
8898423 
Signed-off-by: pranalidhanavade <[email protected]>
@pranalidhanavade
fix:pagination validation
879c79a 
Signed-off-by: pranalidhanavade <[email protected]>
@pranalidhanavade
changes in interface files
a905bcc 
Signed-off-by: pranalidhanavade <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 14, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ankita-p17
ankita-p17 approved these changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@ankita-p17 ankita-p17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankita-p17 ankita-p17 merged commit 3828e82 into develop Jan 14, 2024
2 checks passed
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@pranalidhanavade @KulkarniShashank
fix: validation on pagination (#433)
372d827 
* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:sonacloud issues

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:get invitations

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:excluded delete org api

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:delete org invitations api

Signed-off-by: pranalidhanavade <[email protected]>

* fix:pagination validation

Signed-off-by: pranalidhanavade <[email protected]>

* changes in interface files

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@pranalidhanavade @KulkarniShashank
fix: validation on pagination (#433)
bf80b75 
* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:sonacloud issues

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:get invitations

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:excluded delete org api

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:delete org invitations api

Signed-off-by: pranalidhanavade <[email protected]>

* fix:pagination validation

Signed-off-by: pranalidhanavade <[email protected]>

* changes in interface files

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@pranalidhanavade @KulkarniShashank
fix: validation on pagination (#433)
1c0d034 
* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:sonacloud issues

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:get invitations

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:excluded delete org api

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:delete org invitations api

Signed-off-by: pranalidhanavade <[email protected]>

* fix:pagination validation

Signed-off-by: pranalidhanavade <[email protected]>

* changes in interface files

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@pranalidhanavade @KulkarniShashank
fix: validation on pagination (#433)
ff4e93f 
* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:sonacloud issues

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:get invitations

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:excluded delete org api

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:delete org invitations api

Signed-off-by: pranalidhanavade <[email protected]>

* fix:pagination validation

Signed-off-by: pranalidhanavade <[email protected]>

* changes in interface files

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@pranalidhanavade @KulkarniShashank
fix: validation on pagination (#433)
9b1bf03 
* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:sonacloud issues

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:get invitations

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:excluded delete org api

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:delete org invitations api

Signed-off-by: pranalidhanavade <[email protected]>

* fix:pagination validation

Signed-off-by: pranalidhanavade <[email protected]>

* changes in interface files

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@pranalidhanavade @KulkarniShashank
fix: validation on pagination (#433)
eee3884 
* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:validation issue for pagination

Signed-off-by: pranalidhanavade <[email protected]>

* fix:sonacloud issues

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:get invitations

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:excluded delete org api

Signed-off-by: pranalidhanavade <[email protected]>

* refactor:delete org invitations api

Signed-off-by: pranalidhanavade <[email protected]>

* fix:pagination validation

Signed-off-by: pranalidhanavade <[email protected]>

* changes in interface files

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankita-p17 ankita-p17 ankita-p17 approved these changes

@nishad-ayanworks nishad-ayanworks Awaiting requested review from nishad-ayanworks

Assignees

@pranalidhanavade pranalidhanavade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranalidhanavade @ankita-p17