fix: Passkey fixes #489
Merged
fix: Passkey fixes #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishad <[email protected]>
nishad-ayanworks
requested review from
ankita-p17,
KulkarniShashank and
vivekayanworks
|
tipusinghaw
reviewed
Feb 6, 2024
| @@ -296,6 +296,13 @@ export class UserService { | |||
| throw new NotFoundException(ResponseMessages.user.error.emailNotVerified); | |||
| } | |||
|
|
|||
| const decryptedPassword = await this.commonService.decryptPassword(userInfo.password); | |||
There was a problem hiding this comment.
should we generate the hash of the password and send it to the keycloak?
There was a problem hiding this comment.
Right now we are directly passing the password to the keycloak as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What