Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error handling for endorsement flow #557

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix: error handling for endorsement flow #557

merged 2 commits into from
Feb 29, 2024

Conversation

pranalidhanavade
Copy link
Contributor

What

  • Fixed issue:- Incorrect message displayed when submitting schema with the same name and version that is already submitted on ledger (Endorsement flow).
  • Removed unnecessary logs from issuance and verification services.

@pranalidhanavade pranalidhanavade self-assigned this Feb 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

nishad-ayanworks
nishad-ayanworks approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

KulkarniShashank
KulkarniShashank approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@KulkarniShashank KulkarniShashank merged commit 4bad987 into develop Feb 29, 2024
2 checks passed
@pranalidhanavade pranalidhanavade deleted the ecosystem-error-handling-from-api-response branch March 7, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

@nishad-ayanworks nishad-ayanworks nishad-ayanworks approved these changes

Assignees

@pranalidhanavade pranalidhanavade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranalidhanavade @KulkarniShashank @nishad-ayanworks