Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added geolocation APIs in CREDEBL. #796

Merged
merged 9 commits into from
Jun 24, 2024
Merged

feat: added geolocation APIs in CREDEBL. #796

merged 9 commits into from
Jun 24, 2024

Conversation

ganeshawle25
Copy link
Contributor

What

  • Added geo-location module in api-gateway
  • Integrated geo-location service : Added three different api's for countries,states and cities.
  • Added prisma models for countries,states and cities. Changed organisation modules accordingly.

why

  • For to increase re-usability I have integrated separate service in CREDEBL.

@ganeshawle25 ganeshawle25 self-assigned this Jun 20, 2024
@ganeshawle25
resolved sonar issues
4e3bef1 
Signed-off-by: Ganesh Nawle <[email protected]>
@tipusinghaw tipusinghaw changed the title Feat: added geo-location api's in CREDEBL. feat: added geo-location api's in CREDEBL. Jun 20, 2024
@tipusinghaw tipusinghaw changed the title feat: added geo-location api's in CREDEBL. feat: added geolocation APIs in CREDEBL. Jun 20, 2024
tipusinghaw
tipusinghaw approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshawle25
fix : resovled PR conflicts
b76d29a 
Signed-off-by: Ganesh Nawle <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ganeshawle25 ganeshawle25 merged commit 6d9ba42 into develop Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@shitrerohit shitrerohit Awaiting requested review from shitrerohit

@KulkarniShashank KulkarniShashank Awaiting requested review from KulkarniShashank

Assignees

@ganeshawle25 ganeshawle25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshawle25 @tipusinghaw