Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add condition to check ledgerId is not null #797

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: add condition to check ledgerId is not null #797

merged 1 commit into from
Jun 20, 2024

Conversation

GHkrishna
Copy link
Contributor

What

  • Added the validation for create DID when ledgerId is null

Why

  • When ledgerId is null, DID does not create with a specific ledger

@GHkrishna GHkrishna self-assigned this Jun 20, 2024
pranalidhanavade
pranalidhanavade reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@pranalidhanavade pranalidhanavade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@GHkrishna GHkrishna merged commit b26c3a6 into develop Jun 20, 2024
1 of 2 checks passed
@GHkrishna GHkrishna deleted the fix/create-did-mismatch branch August 28, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranalidhanavade pranalidhanavade pranalidhanavade approved these changes

Assignees

@GHkrishna GHkrishna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GHkrishna @pranalidhanavade