Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support schema for key and web #801

Merged
merged 6 commits into from
Jun 23, 2024
Merged

feat: support schema for key and web #801

merged 6 commits into from
Jun 23, 2024

Conversation

tipusinghaw
Copy link
Contributor

@tipusinghaw tipusinghaw commented Jun 21, 2024 •
edited
Loading

What

  • Supported schema for key and web
  • Insufficient balance implementation
  • Implement a single endpoint for schema creation for all type of schemas

@tipusinghaw tipusinghaw self-assigned this Jun 21, 2024
KulkarniShashank
KulkarniShashank approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

GHkrishna
GHkrishna approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

apps/ledger/src/schema/schema.service.ts Show resolved Hide resolved
apps/ledger/src/schema/schema.service.ts Show resolved Hide resolved
apps/ledger/src/schema/schema.service.ts Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 23, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tipusinghaw tipusinghaw merged commit 72ad46c into develop Jun 23, 2024
2 checks passed
@tipusinghaw tipusinghaw deleted the feat/w3c-schema-for-key-and-web branch June 23, 2024 11:57
KulkarniShashank pushed a commit that referenced this pull request Sep 6, 2024
@tipusinghaw @KulkarniShashank
feat: support schema for key and web (#801)
9235afe 
* feat/fix: added support for did:web and did:key and fix the error handling for schema creation

Signed-off-by: tipusinghaw <[email protected]>

* feat: support for all type of schemas

Signed-off-by: tipusinghaw <[email protected]>

* feat: added noledger enum

Signed-off-by: tipusinghaw <[email protected]>

* fix: added validation for did network

Signed-off-by: tipusinghaw <[email protected]>

---------

Signed-off-by: tipusinghaw <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@tipusinghaw @KulkarniShashank
feat: support schema for key and web (#801)
a7fc32f 
* feat/fix: added support for did:web and did:key and fix the error handling for schema creation

Signed-off-by: tipusinghaw <[email protected]>

* feat: support for all type of schemas

Signed-off-by: tipusinghaw <[email protected]>

* feat: added noledger enum

Signed-off-by: tipusinghaw <[email protected]>

* fix: added validation for did network

Signed-off-by: tipusinghaw <[email protected]>

---------

Signed-off-by: tipusinghaw <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@tipusinghaw @KulkarniShashank
feat: support schema for key and web (#801)
7b60f22 
* feat/fix: added support for did:web and did:key and fix the error handling for schema creation

Signed-off-by: tipusinghaw <[email protected]>

* feat: support for all type of schemas

Signed-off-by: tipusinghaw <[email protected]>

* feat: added noledger enum

Signed-off-by: tipusinghaw <[email protected]>

* fix: added validation for did network

Signed-off-by: tipusinghaw <[email protected]>

---------

Signed-off-by: tipusinghaw <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@tipusinghaw @KulkarniShashank
feat: support schema for key and web (#801)
1297969 
* feat/fix: added support for did:web and did:key and fix the error handling for schema creation

Signed-off-by: tipusinghaw <[email protected]>

* feat: support for all type of schemas

Signed-off-by: tipusinghaw <[email protected]>

* feat: added noledger enum

Signed-off-by: tipusinghaw <[email protected]>

* fix: added validation for did network

Signed-off-by: tipusinghaw <[email protected]>

---------

Signed-off-by: tipusinghaw <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@tipusinghaw @KulkarniShashank
feat: support schema for key and web (#801)
c65a15d 
* feat/fix: added support for did:web and did:key and fix the error handling for schema creation

Signed-off-by: tipusinghaw <[email protected]>

* feat: support for all type of schemas

Signed-off-by: tipusinghaw <[email protected]>

* feat: added noledger enum

Signed-off-by: tipusinghaw <[email protected]>

* fix: added validation for did network

Signed-off-by: tipusinghaw <[email protected]>

---------

Signed-off-by: tipusinghaw <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@tipusinghaw @KulkarniShashank
feat: support schema for key and web (#801)
d23b4a5 
* feat/fix: added support for did:web and did:key and fix the error handling for schema creation

Signed-off-by: tipusinghaw <[email protected]>

* feat: support for all type of schemas

Signed-off-by: tipusinghaw <[email protected]>

* feat: added noledger enum

Signed-off-by: tipusinghaw <[email protected]>

* fix: added validation for did network

Signed-off-by: tipusinghaw <[email protected]>

---------

Signed-off-by: tipusinghaw <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@tipusinghaw @KulkarniShashank
feat: support schema for key and web (#801)
254cf30 
* feat/fix: added support for did:web and did:key and fix the error handling for schema creation

Signed-off-by: tipusinghaw <[email protected]>

* feat: support for all type of schemas

Signed-off-by: tipusinghaw <[email protected]>

* feat: added noledger enum

Signed-off-by: tipusinghaw <[email protected]>

* fix: added validation for did network

Signed-off-by: tipusinghaw <[email protected]>

---------

Signed-off-by: tipusinghaw <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

@GHkrishna GHkrishna GHkrishna approved these changes

@bhavanakarwade bhavanakarwade Awaiting requested review from bhavanakarwade

Assignees

@tipusinghaw tipusinghaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tipusinghaw @KulkarniShashank @GHkrishna