Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gracefully handle missing deeplink domain url from env #894

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix: gracefully handle missing deeplink domain url from env #894

merged 1 commit into from
Aug 5, 2024

Conversation

GHkrishna
Copy link
Contributor

What:

  • Gracefully handle missing environment variable for deeplink domain url

Why:

  • Currently with missing env variable, the exception results in unexpected errors

@GHkrishna GHkrishna added the enhancement New feature or request label Aug 5, 2024
@GHkrishna GHkrishna self-assigned this Aug 5, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

KulkarniShashank
KulkarniShashank approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@GHkrishna GHkrishna merged commit 724593e into develop Aug 5, 2024
2 checks passed
@GHkrishna GHkrishna deleted the fix/handle-missing-deeplink-domain branch August 5, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

@bhavanakarwade bhavanakarwade bhavanakarwade approved these changes

Assignees

@GHkrishna GHkrishna

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GHkrishna @KulkarniShashank @bhavanakarwade