Compatibility with [email protected] toolchain (WIP) #30
Conversation
| let hitCount = 0; | ||
| const server = Dgram.createSocket('udp4'); | ||
| server.on('message', (msg) => { | ||
| hitCount += 1; | ||
| validateResponses(msg.toString(), expectedNumberOfEvents, expectedMsg); | ||
|
|
||
| if (hitCount >= 2) { | ||
| server.close(done); | ||
| server.close(); |
There was a problem hiding this comment.
Two test failures in the Travis build. Perhaps you still need to pass a callback?
There was a problem hiding this comment.
Yes, the methods still need async/await calls, but my 4:30 AM self had problems getting it running. 😀 – That's basically why I labeled it "WIP".
| @@ -1,5 +1,4 @@ | |||
| language: node_js | |||
| node_js: | |||
| - 7 | |||
| - 6 | |||
| - 4 | |||
There was a problem hiding this comment.
I'm very excited about node 8 => mostly for the improved V8 engine performance, but also for async/await. That said, is it time to deprecate node 4 - 6? Node 8 only became LTS last week. Though I guess since most Hapi modules seem to have moved it's probably time?
There was a problem hiding this comment.
That's why this change is a breaking semver change. People using older versions of Node can still use the current release. I should make this more clearer in the README.
Update tests to be compatible with the new
labversion and[email protected]TODO:
mocks.getHttpServerandmocks.getUdpServerneed to be updated usingasync/await.Refs:
EDIT:
gooditself is not yet compatible with hapi 17 yet, waiting for a decision there.