fix version detection for backwards compatability #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Maybe I didn't test enough. I used the nightly build and could not get an error before or after the previous changes... I'll take another look. |
|
Have you had a chance to test this, yet? |
|
Not at all, sorry. I'll take care of it today. |
|
looks fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
thanks for the quick response to #78.
There is still an issue around the missing ChangeLog file in development builds.
I've proposed some changes to handle version comparison in case there is no ChangeLog file.
If we are in a development build with a ChangeLog file, we read the latest release version from the ChangeLog file and compare it.
If we are in a development build without a ChangeLog file, then we can be sure that it's a version higher than is needed for the compatibility classes.
If it's a regular release build, the release version gets compared to determine whether compatibility classes are needed or not.
This has worked for me in the following three test scenarios: