Make the count string customizable

[abo-abo]

• ido-vertical-mode.el (ido-vertical-show-count): Update.
• (ido-vertical-count-active): Remove.
• (ido-vertical-completions): Modify `ido-decorations' instead.
• (turn-on-ido-vertical): Use copy-sequence so that ido-vertical-decorations doesn't have to be modified.

[abo-abo]

Here's my current config that's enabled by the last change:

(use-package ido-vertical-mode
    :config
  (setf (nth 0 ido-vertical-decorations) "\n")
  (setf (nth 2 ido-vertical-decorations) "\n")
  (setf (nth 11 ido-vertical-decorations) "\n")
  (ido-vertical-mode 1))

[gempesaw]

Hey, thanks for the PR!

I don't understand the summary here in the PR, or the commit messages, or how it relates to the config changes here. Can you explain it a bit, or split out the commits into more logical chunks? The messages are too terse for me.

Also, the CI tests are failing.

I initially had a suspicion that this should should be broken into two PRs (one for customizing count string, one for refactoring & simplifying the text-face handling), but after looking at the code again, I can't tell if they're all related or not...

[abo-abo]

The commits simplify the code and make it more customizable.
This is what I currently have by just customizing ido-vertical-mode:

The main point is to re-use ido-vertical-decorations everywhere, so that when they are customized, everything is consistent. I recomment to use magit and ediff with "-w" parameter to look at the Elisp diffs: it makes them look a lot simpler.

[gempesaw]

Hmm, that looks like the after image, I guess, since the count string uses parens instead of brackets?And, the main point isn't about the count string at all then. Ah, with that in mind, I took another look and it makes a bit more sense. Oh, I see - the commits themselves seem to be entirely independent of each other & unrelated, but the summary view showed all the changes together, which made things less clear. Hm, separate PRs would've helped, but no big deal, it makes sense now.

I'll see if I have some time to figure out why the test is failing.