Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Add singleAttributePerLine: true to prettier config #1200

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aaronb97
Copy link
Contributor

Prettier added this new parameter singleAttributePerLIne a little bit ago and I'm not sure if I'm a fan. I think would be a win for cleaner diffs and PRs though

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db716e0) 100.00% compared to head (725610b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roblafeve
Copy link
Contributor

Prettier added this new parameter singleAttributePerLIne a little bit ago and I'm not sure if I'm a fan. I think would be a win for cleaner diffs and PRs though

Hmmm... yeah that's interesting. Wonder what it would feel like in an actual project. Definitely would clean up diffs.

@roblafeve
Copy link
Contributor

@aaronb97 what's your current thinking on this?

@aaronb97
Copy link
Contributor Author

I think it would * probably * be good for new projects... but I think adding it to a project that's been around for a while might mess up the git blame too much

@roblafeve
Copy link
Contributor

I feel like this is something we should try out before enabling it in the template

@aaronb97
Copy link
Contributor Author

I feel like this is something we should try out before enabling it in the template

crema-components it is

@aaronb97 aaronb97 marked this pull request as ready for review January 19, 2024 18:09
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants