-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] Add singleAttributePerLine: true to prettier config #1200
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1200 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 ☔ View full report in Codecov by Sentry. |
Hmmm... yeah that's interesting. Wonder what it would feel like in an actual project. Definitely would clean up diffs. |
@aaronb97 what's your current thinking on this? |
I think it would * probably * be good for new projects... but I think adding it to a project that's been around for a while might mess up the git blame too much |
I feel like this is something we should try out before enabling it in the template |
crema-components it is |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Prettier added this new parameter
singleAttributePerLIne
a little bit ago and I'm not sure if I'm a fan. I think would be a win for cleaner diffs and PRs though