Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for: #10 small issue in correct baseline method #11

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

gchure
Copy link
Member

@gchure gchure commented Jan 23, 2024

This fixes the bug identified in #10 and improves the test dataset for fitting many peaks.

@gchure gchure linked an issue Jan 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ce5223) 97.06% compared to head (24a56b3) 97.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files           3        3           
  Lines         545      545           
=======================================
  Hits          529      529           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gchure gchure merged commit 14bb8d9 into main Jan 23, 2024
5 checks passed
@gchure gchure deleted the 10-small-issue-in-correct_baseline-method branch January 23, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small issue in correct_baseline method
1 participant