Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMTD-GC segfaults on atoms and diatoms #320

Closed
jevandezande opened this issue Jul 18, 2024 · 2 comments
Closed

IMTD-GC segfaults on atoms and diatoms #320

jevandezande opened this issue Jul 18, 2024 · 2 comments

Comments

@jevandezande
Copy link
Contributor

The imtd-gc method segfaults almost immediately if a geometry with a single atom is given. If a geometry with two atoms is given, it typically fails in the trial MTDs, otherwise it fails due to an "empty ensemble filecrest_rotamers.xyz" or segfaults in the Multilevel Ensemble Optimization.

Obviously, nobody should run these, but it would be preferable if CREST would failover to an optimization if 3 or fewer atoms were requested and fake that it ran imtd-gc by outputting the usual crest_conformers.xyz, crest_best.xyz, etc. files.

@pprcht
Copy link
Contributor

pprcht commented Jul 18, 2024

It did that previously.
I will check if/where it needs to be reinstated.
Thanks for noticing.

pprcht added a commit that referenced this issue Jul 19, 2024
@pprcht
Copy link
Contributor

pprcht commented Jul 19, 2024

#322 should take care of it.

@pprcht pprcht closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants