-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Sign your PR" reminder is missing in CONTRIBUTING.md #59
Comments
good find! |
do you have interest in submitting a PR to fix (or include it in #58) or would you like me to? |
@haircommander Sure, I can do that, I just wanted to ask if you want me to just add the link to the other repository or it is better to paste the entire section text here as well? |
Signed-off-by: Lenka Bocincova <[email protected]>
I find myself thinking about maintenance overhead. Maybe adding a line |
@haircommander good thinking! Let me add a commit to my opened PR. |
Signed-off-by: Lenka Bocincova <[email protected]>
Signed-off-by: Lenka Bocincova <[email protected]>
Signed-off-by: Lenka Bocincova <[email protected]>
Contributing.md doesn't mention sign-off. I realized that only after creating PR, that I am missing my signature. Adding it there would be very helpful for a new contributor.
Adding the same section as it is in this repository could fix it: https://github.com/cri-o/cri-o/blob/main/CONTRIBUTING.md#sign-your-prs
The text was updated successfully, but these errors were encountered: