[1.11] Remove "container PID" logs from conmon #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
/test all |
k8s-ci-robot
added
size/M
k8s-ci-robot
added
size/M
|
Fix the problems Travis is complaining about and squash your PR and this LGTM. |
umohnani8
force-pushed
the
1.11
branch
2 times, most recently
from
89abc3d
to
5ac2cda
Compare
k8s-ci-robot
added
size/S
|
LGTM once the tests are fixed up. |
conmon now has a --log-level flag that changes the verbosity of the logs based on the value it is set to. From logrus, panic(0), fatal(1), error(2) tells conmon to print all pexit and nexit logs (this is the default). warn(3) adds the nwarn logs, info(4) adds the ninfo logs, and finally debug(5) adds the ndebug logs as well. Adds a log_level field in the crio.conf that can have the following options: panic, fatal, error, warn, info, and debug. Changes default from info to error. Signed-off-by: umohnani8 <[email protected]>
k8s-ci-robot
added
size/L
|
/test all |
|
/test e2e_rhel |
1 similar comment
|
/test e2e_rhel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs were filling up quite a bit due to the logs
in conmon printing out the container PID info.
Signed-off-by: umohnani8 [email protected]